Peter Zijlstra 1054598cab perf_counter: Fix double list iteration in per task precise stats ...

Brice Goglin reported this crash with per task precise stats:

> I finally managed to test the threaded perfcounter statistics (thanks a
> lot for implementing it). I am running 2.6.31-rc5 (with the AMD
> magny-cours patches but I don't think they matter here). I am trying to
> measure local/remote memory accesses per thread during the well-known
> stream benchmark. It's compiled with OpenMP using 16 threads on a
> quad-socket quad-core barcelona machine.
>
> Command line is:
>  /mnt/scratch/bgoglin/cpunode/linux-2.6.31/tools/perf/perf record -f -s
> -e r1000001e0 -e r1000002e0 -e r1000004e0 -e r1000008e0 ./stream
>
> It seems to work fine with a single -e <counter> on the command line
> while it crashes when there are at least 2 of them.
> It seems to work fine without -s as well.

A silly copy-paste resulted in a messed up iteration which would
cause the OOPS.

Reported-by: Brice Goglin <Brice.Goglin@inria.fr>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Tested-by: Brice Goglin <Brice.Goglin@inria.fr>
LKML-Reference: <1249574786.32113.550.camel@twins>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

2009-08-06 20:25:18 +02:00

..

gcov

gcov: enable GCOV_PROFILE_ALL for x86_64

2009-06-18 13:03:58 -07:00

irq

genirq: Fix UP compile failure caused by irq_thread_check_affinity

2009-07-22 23:18:46 +02:00

power

headers: smp_lock.h redux

2009-07-12 12:22:34 -07:00

time

clocksource: Prevent NULL pointer dereference

2009-07-19 17:15:54 +02:00

trace

ftrace: Fix perf-tracepoint OOPS

2009-08-06 06:26:09 +02:00

.gitignore

…

acct.c

bsdacct: fix access to invalid filp in acct_on()

2009-06-30 18:56:00 -07:00

async.c

async: Fix lack of boot-time console due to insufficient synchronization

2009-06-08 12:31:53 -07:00

audit_tree.c

Fix rule eviction order for AUDIT_DIR

2009-06-24 00:02:38 -04:00

audit_watch.c

Audit: clean up all op= output to include string quoting

2009-06-24 00:00:52 -04:00

audit.c

Fix rule eviction order for AUDIT_DIR

2009-06-24 00:02:38 -04:00

audit.h

Fix rule eviction order for AUDIT_DIR

2009-06-24 00:02:38 -04:00

auditfilter.c

Audit: clean up all op= output to include string quoting

2009-06-24 00:00:52 -04:00

auditsc.c

Fix rule eviction order for AUDIT_DIR

2009-06-24 00:02:38 -04:00

backtracetest.c

…

bounds.c

…

capability.c

[CVE-2009-0029] System call wrappers part 04

2009-01-14 14:15:19 +01:00

cgroup_debug.c

debug cgroup: remove unneeded cgroup_lock

2009-04-02 19:04:54 -07:00

cgroup_freezer.c

freezer_cg: disable writing freezer.state of root cgroup

2008-11-12 17:17:16 -08:00

cgroup.c

cgroup avoid permanent sleep at rmdir

2009-07-29 19:10:35 -07:00

compat.c

signals: implement sys_rt_tgsigqueueinfo

2009-04-30 19:24:24 +02:00

configs.c

kernel/configs.c: remove useless comments

2008-10-20 08:52:34 -07:00

cpu.c

mm/init: cpu_hotplug_init() must be initialized before SLAB

2009-06-22 21:18:12 -07:00

cpuset.c

cpuset,mm: update tasks' mems_allowed in time

2009-06-16 19:47:31 -07:00

cred-internals.h

CRED: Inaugurate COW credentials

2008-11-14 10:39:23 +11:00

cred.c

CRED: Rename cred_exec_mutex to reflect that it's a guard against ptrace

2009-05-11 08:15:36 +10:00

delayacct.c

schedstat: consolidate per-task cpu runtime stats

2008-12-18 13:54:01 +01:00

dma-coherent.c

dma-coherent: Restore dma_alloc_from_coherent() large alloc fall back policy.

2009-01-21 18:51:53 +09:00

dma.c

kernel/dma.c: remove a CVS keyword

2008-10-16 11:21:30 -07:00

exec_domain.c

Get rid of indirect include of fs_struct.h

2009-03-31 23:00:27 -04:00

exit.c

headers: mnt_namespace.h redux

2009-07-08 09:31:56 -07:00

extable.c

Merge branch 'tracing-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-04-05 11:04:19 -07:00

fork.c

perf_counter: Full task tracing

2009-08-02 13:47:56 +02:00

freezer.c

sched: fix nr_uninterruptible accounting of frozen tasks really

2009-07-18 14:19:53 +02:00

futex_compat.c

CRED: Use RCU to access another task's creds and to release a task's own creds

2008-11-14 10:39:19 +11:00

futex.c

futexes: Fix infinite loop in get_futex_key() on huge page

2009-07-11 12:40:44 +02:00

groups.c

groups: move code to kernel/groups.c

2009-06-16 19:47:48 -07:00

hrtimer.c

hrtimer: Fix migration expiry check

2009-07-10 17:32:55 +02:00

hung_task.c

softlockup: ensure the task has been switched out once

2009-02-11 11:04:16 +01:00

itimer.c

timers: split process wide cpu clocks/timers

2009-02-05 13:04:33 +01:00

kallsyms.c

kernel/kallsyms.c: replace deprecated __initcall with device_initcall and fix whitespace

2009-06-09 22:37:52 +02:00

Kconfig.freezer

container freezer: implement freezer cgroup subsystem

2008-10-20 08:52:34 -07:00

Kconfig.hz

…

Kconfig.preempt

rcu: provide RCU options on non-preempt architectures too

2008-12-25 09:31:28 +01:00

kexec.c

kexec: fix omitting offset in extended crashkernel syntax

2009-07-29 19:10:34 -07:00

kfifo.c

kernel/kfifo.c: replace conditional test with is_power_of_2()

2009-06-16 19:47:47 -07:00

kgdb.c

sysrq, intel_fb: fix sysrq g collision

2009-05-15 07:56:24 -05:00

kmod.c

headers: mnt_namespace.h redux

2009-07-08 09:31:56 -07:00

kprobes.c

kprobes: Use kernel_text_address() for checking probe address

2009-07-30 16:44:06 -07:00

ksysfs.c

kernel/ksysfs.c:fix dependence on CONFIG_NET

2009-01-06 10:44:31 -08:00

kthread.c

update the comment in kthread_stop()

2009-07-27 12:15:46 -07:00

latencytop.c

sched, latencytop: incorporate review feedback from Andrew Morton

2009-02-11 10:18:04 +01:00

lockdep_internals.h

lockdep: increase MAX_LOCKDEP_ENTRIES and MAX_LOCKDEP_CHAINS

2009-05-12 19:59:52 +02:00

lockdep_proc.c

lockstat: warn about disabled lock debugging

2009-02-14 23:28:28 +01:00

lockdep_states.h

lockdep: move state bit definitions around

2009-02-14 23:27:59 +01:00

lockdep.c

Merge branch 'linus' into tracing/core

2009-05-07 11:17:34 +02:00

Makefile

Merge branch 'tracing-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-06-28 11:05:04 -07:00

marker.c

markers/tracpoints: fix non-modular build

2008-11-16 09:52:03 +01:00

module.c

module: use MODULE_SYMBOL_PREFIX with module_layout

2009-07-27 12:15:45 -07:00

mutex-debug.c

mutex: implement adaptive spinning

2009-01-14 18:09:02 +01:00

mutex-debug.h

mutex: implement adaptive spinning

2009-01-14 18:09:02 +01:00

mutex.c

Merge branch 'linus' into perfcounters/core

2009-06-11 17:55:42 +02:00

mutex.h

mutex: implement adaptive spinning

2009-01-14 18:09:02 +01:00

notifier.c

Merge commit 'v2.6.28-rc6' into core/debug

2008-11-26 08:22:50 +01:00

ns_cgroup.c

cgroups: relax ns_can_attach checks to allow attaching to grandchild cgroups

2009-04-02 19:04:53 -07:00

nsproxy.c

nsproxy: extract create_nsproxy()

2009-06-18 13:03:56 -07:00

panic.c

trace: stop tracer in oops_enter()

2009-07-24 15:30:45 -04:00

params.c

module_param: allow 'bool' module_params to be bool, not just int.

2009-06-12 21:46:58 +09:30

perf_counter.c

perf_counter: Fix double list iteration in per task precise stats

2009-08-06 20:25:18 +02:00

pid_namespace.c

pidns: rewrite copy_pid_ns()

2009-06-18 13:03:55 -07:00

pid.c

kmemleak: Remove alloc_bootmem annotations introduced in the past

2009-07-09 17:07:02 +01:00

pm_qos_params.c

…

posix-cpu-timers.c

kernel/posix-cpu-timers.c: fix sparse warning

2009-04-30 08:08:31 +02:00

posix-timers.c

posix-timers: Fix oops in clock_nanosleep() with CLOCK_MONOTONIC_RAW

2009-08-04 10:16:41 +02:00

printk.c

printk: Add KERN_DEFAULT printk log-level

2009-06-16 11:02:28 -07:00

profile.c

profile: suppress warning about large allocations when profile=1 is specified

2009-07-29 19:10:36 -07:00

ptrace.c

cred_guard_mutex: do not return -EINTR to user-space

2009-07-06 13:57:04 -07:00

rcuclassic.c

kmemtrace, rcu: fix linux/rcutree.h and linux/rcuclassic.h dependencies

2009-04-03 12:23:02 +02:00

rcupdate.c

RCU: Don't try and predeclare inline funcs as it upsets some versions of gcc

2009-04-15 13:55:14 -07:00

rcupreempt_trace.c

"Tree RCU": scalable classic RCU implementation

2008-12-18 21:56:04 +01:00

rcupreempt.c

rcu: rcu_sched_grace_period(): kill the bogus flush_signals()

2009-05-05 20:28:05 +02:00

rcutorture.c

cpumask: convert rcutorture.c

2009-03-30 22:05:16 +10:30

rcutree_trace.c

rcu: Add __rcu_pending tracing to hierarchical RCU

2009-04-14 11:33:43 +02:00

rcutree.c

rcu: Mark Hierarchical RCU no longer experimental

2009-06-24 15:02:48 +02:00

rcutree.h

kmemtrace, rcu: fix rcu_tree_trace.c data structure dependencies

2009-04-03 12:23:03 +02:00

relay.c

Merge branch 'tracing-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-04-05 11:04:19 -07:00

res_counter.c

memcg: add interface to reset limits

2009-06-18 13:03:48 -07:00

resource.c

kernel/resource.c: fix sign extension in reserve_setup()

2009-06-30 18:56:00 -07:00

rtmutex_common.h

rt_mutex: add proxy lock routines

2009-04-06 11:14:02 +02:00

rtmutex-debug.c

…

rtmutex-debug.h

…

rtmutex-tester.c

…

rtmutex.c

trivial: fix ETIMEOUT -> ETIMEDOUT typos

2009-06-12 18:01:50 +02:00

rtmutex.h

…

rwsem.c

…

sched_clock.c

sched: Fix fallback sched_clock()'s offset when using jiffies

2009-05-09 10:08:19 +02:00

sched_cpupri.c

sched: Fix race in cpupri introduced by cpumask_var changes

2009-08-02 14:23:29 +02:00

sched_cpupri.h

cpumask: remove cpumask_t from core

2009-03-30 22:05:17 +10:30

sched_debug.c

sched: Hide runqueues from direct refer at source code level

2009-06-17 18:29:42 +02:00

sched_fair.c

sched: Fix latencytop and sleep profiling vs group scheduling

2009-08-02 14:10:12 +02:00

sched_features.h

Merge branch 'locking-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-03-30 17:17:35 -07:00

sched_idletask.c

sched, timers: move calc_load() to scheduler

2009-05-15 15:32:45 +02:00

sched_rt.c

sched_rt: Fix overload bug on rt group scheduling

2009-07-10 10:43:29 +02:00

sched_stats.h

sched: remove unused fields from struct rq

2009-03-24 23:16:51 +01:00

sched.c

sched: fix load average accounting vs. cpu hotplug

2009-07-18 14:19:52 +02:00

seccomp.c

x86-64: seccomp: fix 32/64 syscall hole

2009-03-02 15:41:30 -08:00

semaphore.c

…

signal.c

do_sigaltstack: small cleanups

2009-08-01 11:18:56 -07:00

slow-work.c

slow-work: use round_jiffies() for thread pool's cull and OOM timers

2009-06-16 19:47:49 -07:00

smp.c

cpumask: alloc zeroed cpumask for static cpumask_var_ts

2009-06-09 22:30:27 +09:30

softirq.c

softirq: introduce tasklet_hrtimer infrastructure

2009-07-22 17:01:17 +02:00

softlockup.c

softlockup: decouple hung tasks check from softlockup detection

2009-01-16 14:06:04 +01:00

spinlock.c

Allow rwlocks to re-enable interrupts

2009-04-02 19:05:11 -07:00

srcu.c

…

stacktrace.c

stacktrace: provide save_stack_trace_tsk() weak alias

2008-12-25 11:44:43 +01:00

stop_machine.c

cpumask: remove cpumask_t from core

2009-03-30 22:05:17 +10:30

sys_ni.c

Merge commit 'v2.6.29-rc2' into perfcounters/core

2009-01-21 16:37:27 +01:00

sys.c

groups: move code to kernel/groups.c

2009-06-16 19:47:48 -07:00

sysctl_check.c

net: add ARP notify option for devices

2009-02-01 01:04:33 -08:00

sysctl.c

Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-06-28 11:05:28 -07:00

taskstats.c

cpumask: convert rest of files in kernel/

2009-01-01 10:12:28 +10:30

test_kprobes.c

kprobes: add tests for register_kprobes

2009-01-06 15:59:20 -08:00

time.c

[CVE-2009-0029] System call wrappers part 01

2009-01-14 14:15:18 +01:00

timeconst.pl

…

timer.c

timer: Avoid reading uninitialized data

2009-07-18 23:11:43 +02:00

tracepoint.c

tracepoints: dont update zero-sized tracepoint sections

2009-03-18 19:55:00 +01:00

tsacct.c

Fix fixpoint divide exception in acct_update_integrals

2009-03-09 08:13:35 -07:00

uid16.c

[CVE-2009-0029] System call wrappers part 19

2009-01-14 14:15:26 +01:00

up.c

smp_call_function_single(): be slightly less stupid, fix #2

2009-01-12 16:04:37 +01:00

user_namespace.c

Fix recursive lock in free_uid()/free_user_ns()

2009-02-27 16:26:21 -08:00

user.c

sched: delayed cleanup of user_struct

2009-06-15 21:30:23 -07:00

utsname_sysctl.c

proc_sysctl: use CONFIG_PROC_SYSCTL around ipc and utsname proc_handlers

2009-04-02 19:05:01 -07:00

utsname.c

utsns: extract creeate_uts_ns()

2009-06-18 13:03:55 -07:00

wait.c

wait: don't use __wake_up_common()

2009-04-14 17:17:16 +02:00

workqueue.c

ftrace, workqueuetrace: make workqueue tracepoints use TRACE_EVENT macro

2009-06-02 01:10:40 +02:00