mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-23 10:45:57 -04:00
7de02fe953
Fix a sysfs duplication error when reinitializing the device: sysfs: cannot create duplicate filename '.../ip_discovery' kobject_add_internal failed for ip_discovery with -EEXIST ... Failed to create device file mem_info_preempt_used (-17) The failure is caused by stale sysfs entries not being removed during device teardown, leading to -EEXIST when the driver is reprobed. In particular: - amdgpu_discovery sysfs kobjects were not fully torn down early enough, and ip_top remained non-NULL after cleanup - the preempt manager sysfs attribute was removed only conditionally and not during the common hw fini path Fix this by: - making amdgpu_discovery_sysfs_fini() externally visible and clearing adev->discovery.ip_top to prevent reuse - calling amdgpu_discovery_sysfs_fini() and amdgpu_preempt_mgr_sysfs_fini() from amdgpu_device_sys_interface_fini() This ensures sysfs state is fully cleaned up before reprobe and avoids duplicate kobject/file creation. Cc: Christian König <christian.koenig@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Geoffrey McRae <geoffrey.mcrae@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
63 lines
2.3 KiB
C
63 lines
2.3 KiB
C
/*
|
|
* Copyright 2018 Advanced Micro Devices, Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
*/
|
|
|
|
#ifndef __AMDGPU_DISCOVERY__
|
|
#define __AMDGPU_DISCOVERY__
|
|
|
|
#include <linux/debugfs.h>
|
|
|
|
#define DISCOVERY_TMR_SIZE (10 << 10)
|
|
#define DISCOVERY_TMR_OFFSET (64 << 10)
|
|
|
|
struct ip_discovery_top;
|
|
struct drm_printer;
|
|
|
|
struct amdgpu_discovery_info {
|
|
struct debugfs_blob_wrapper debugfs_blob;
|
|
struct ip_discovery_top *ip_top;
|
|
uint64_t offset;
|
|
uint32_t size;
|
|
uint8_t *bin;
|
|
bool reserve_tmr;
|
|
};
|
|
|
|
void amdgpu_discovery_sysfs_fini(struct amdgpu_device *adev);
|
|
void amdgpu_discovery_fini(struct amdgpu_device *adev);
|
|
int amdgpu_discovery_set_ip_blocks(struct amdgpu_device *adev);
|
|
|
|
int amdgpu_discovery_get_nps_info(struct amdgpu_device *adev,
|
|
uint32_t *nps_type,
|
|
struct amdgpu_gmc_memrange *ranges,
|
|
int *range_cnt, bool refresh);
|
|
int amdgpu_discovery_get_gc_major_minor_version(struct amdgpu_device *adev,
|
|
uint16_t *major, uint16_t *minor);
|
|
|
|
void amdgpu_discovery_dump(struct amdgpu_device *adev, struct drm_printer *p);
|
|
|
|
/* Early sysfs functions for persistent ip_discovery export */
|
|
int amdgpu_discovery_sysfs_early_init(struct amdgpu_device *adev,
|
|
struct pci_dev *pdev);
|
|
void amdgpu_discovery_sysfs_early_fini(struct pci_dev *pdev);
|
|
|
|
#endif /* __AMDGPU_DISCOVERY__ */
|