Files
linux/drivers
Eric Dumazet 59cbf56fcd vxlan: test dev->flags & IFF_UP before calling gro_cells_receive()
Same reasons than the ones explained in commit 4179cb5a4c
("vxlan: test dev->flags & IFF_UP before calling netif_rx()")

netif_rx() or gro_cells_receive() must be called under a strict contract.

At device dismantle phase, core networking clears IFF_UP
and flush_all_backlogs() is called after rcu grace period
to make sure no incoming packet might be in a cpu backlog
and still referencing the device.

A similar protocol is used for gro_cells infrastructure, as
gro_cells_destroy() will be called only after a full rcu
grace period is observed after IFF_UP has been cleared.

Most drivers call netif_rx() from their interrupt handler,
and since the interrupts are disabled at device dismantle,
netif_rx() does not have to check dev->flags & IFF_UP

Virtual drivers do not have this guarantee, and must
therefore make the check themselves.

Otherwise we risk use-after-free and/or crashes.

Fixes: d342894c5d ("vxlan: virtual extensible lan")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-10 11:05:52 -07:00
..
2019-01-10 13:39:19 +02:00
2018-12-29 08:20:44 -07:00
2019-02-20 11:40:21 -08:00
2018-12-10 10:17:45 +01:00
2019-03-04 15:32:51 +00:00
2019-02-28 14:05:33 +10:00
2019-01-09 19:20:31 -05:00
2019-02-01 15:53:54 +01:00
2019-03-01 09:50:10 +01:00
2018-12-06 15:45:46 +01:00
2018-12-24 12:06:56 +01:00
2019-03-04 15:32:51 +00:00
2018-11-11 12:58:27 -08:00
2018-11-12 10:33:49 +01:00