Files
linux/drivers
H Hartley Sweeten 01dc2a05f4 staging: comedi: adl_pci9118: fix the ai cmd->start_arg validation and use
This driver supports three cmd->start_src values, TRIG_NOW, TRIG_EXT, and
TRIG_INT. TRIG_NOW sources should always have an arg of 0 and arg for TRIG_EXT
sources is driver specific. This driver does not use the cmd->start_arg with
the TRIG_EXT source so a trivial value of 0 is good.

When the cmd->start_src is TRIG_INT the cmd->start_arg is actually the valid
trig_num that is passed to the async (*inttrig) callback. This driver allows
any value to be used and currently carries that value in the private data.

Refactor the (*do_cmdtest) so that the trivial validation of the cmd->start_arg
is clear.

Refactor the (*inttrig) so that the cmd->start_arg is used directly to check
the trig_num and remove the then unused 'ai_inttrig_start' member from the
private data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-22 10:21:30 -07:00
..
2014-04-08 21:34:51 +02:00
2014-04-08 13:28:02 +02:00
2014-04-08 13:27:40 +02:00
2014-04-18 16:40:08 -07:00
2014-04-08 13:27:40 +02:00
2014-04-18 16:40:08 -07:00
2014-04-16 12:28:47 -07:00
2014-04-18 16:40:08 -07:00
2014-04-15 15:21:22 -05:00
2014-04-18 16:40:08 -07:00
2014-04-16 14:04:59 -07:00
2014-04-16 14:03:40 -07:00
2014-04-16 14:07:51 -07:00