Jon Maxwell 0048369055
tcp: Add mark for TIMEWAIT sockets ...
This version has some suggestions by Eric Dumazet:
- Use a local variable for the mark in IPv6 instead of ctl_sk to avoid SMP
races.
- Use the more elegant "IP4_REPLY_MARK(net, skb->mark) ?: sk->sk_mark"
statement.
- Factorize code as sk_fullsock() check is not necessary.
Aidan McGurn from Openwave Mobility systems reported the following bug:
"Marked routing is broken on customer deployment. Its effects are large
increase in Uplink retransmissions caused by the client never receiving
the final ACK to their FINACK - this ACK misses the mark and routes out
of the incorrect route."
Currently marks are added to sk_buffs for replies when the "fwmark_reflect"
sysctl is enabled. But not for TW sockets that had sk->sk_mark set via
setsockopt(SO_MARK..).
Fix this in IPv4/v6 by adding tw->tw_mark for TIME_WAIT sockets. Copy the the
original sk->sk_mark in __inet_twsk_hashdance() to the new tw->tw_mark location.
Then progate this so that the skb gets sent with the correct mark. Do the same
for resets. Give the "fwmark_reflect" sysctl precedence over sk->sk_mark so that
netfilter rules are still honored.
Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com >
Reviewed-by: Eric Dumazet <edumazet@google.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2018-05-10 17:44:52 -04:00
2017-07-11 06:08:58 -04:00
2018-04-08 17:19:15 -04:00
2018-01-19 14:02:12 -05:00
2017-11-27 16:20:04 -05:00
2018-05-06 23:33:47 +02:00
2018-04-25 13:02:15 -04:00
2017-04-05 10:15:20 +02:00
2017-10-07 23:15:08 +01:00
2018-05-01 12:09:35 -04:00
2018-01-23 19:51:46 -05:00
2017-04-12 22:02:36 +02:00
2018-03-23 21:52:19 -04:00
2018-04-17 13:39:51 -04:00
2015-09-17 13:20:05 +02:00
2018-03-27 23:03:00 +01:00
2017-11-02 11:10:55 +01:00
2017-10-05 18:44:17 -07:00
2017-11-02 11:10:55 +01:00
2018-01-15 14:53:43 -05:00
2017-11-02 11:10:55 +01:00
2018-02-14 11:55:33 -05:00
2018-04-19 16:11:11 -04:00
2016-02-09 04:45:49 -05:00
2017-05-27 18:51:41 -04:00
2017-10-25 10:54:39 +09:00
2017-08-11 14:59:24 -07:00
2017-07-04 22:35:16 +01:00
2018-03-29 14:01:27 +02:00
2016-07-08 12:20:57 +02:00
2017-01-20 12:12:13 -05:00
2017-07-04 01:29:04 -07:00
2016-04-19 20:09:25 -04:00
2016-04-25 16:44:27 -04:00
2016-06-25 12:19:35 -04:00
2016-04-25 16:44:27 -04:00
2018-04-02 20:16:17 +02:00
2017-11-02 11:10:55 +01:00
2018-04-08 12:45:57 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-18 12:39:36 +01:00
2017-11-30 09:54:25 -05:00
2017-11-04 09:26:51 +09:00
2018-04-27 11:53:03 -04:00
2017-11-02 11:10:55 +01:00
2018-03-05 12:52:45 -05:00
2017-11-04 09:26:51 +09:00
2017-11-02 11:10:55 +01:00
2018-03-05 12:52:45 -05:00
2018-02-06 11:32:48 -05:00
2017-11-02 11:10:55 +01:00
2018-02-28 11:43:28 -05:00
2017-11-01 11:50:43 +09:00
2018-04-23 10:21:24 -04:00
2017-11-02 11:10:55 +01:00
2018-05-08 00:02:36 -04:00
2018-03-04 13:04:23 -05:00
2017-11-02 11:10:55 +01:00
2017-10-30 21:09:24 +09:00
2017-10-11 09:49:34 +02:00
2017-11-02 11:10:55 +01:00
2017-12-08 13:32:26 -05:00
2017-11-16 10:49:00 +09:00
2017-11-02 11:10:55 +01:00
2018-02-27 14:46:26 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-12-11 14:10:06 -05:00
2017-11-02 11:10:55 +01:00
2016-04-27 22:48:25 -04:00
2018-02-22 21:13:02 +01:00
2016-01-04 20:40:41 +01:00
2018-04-19 15:40:13 -04:00
2018-04-22 21:12:00 -04:00
2015-12-15 23:25:20 -05:00
2017-01-18 13:04:28 -05:00
2017-08-07 11:39:22 -07:00
2018-03-31 02:15:43 +02:00
2018-05-10 17:43:55 -04:00
2017-11-04 09:26:51 +09:00
2018-03-31 23:25:39 -04:00
2017-12-03 10:18:28 -05:00
2018-04-26 15:08:04 -04:00
2018-05-10 17:44:52 -04:00
2017-11-02 11:10:55 +01:00
2016-03-13 23:55:13 -04:00
2018-05-04 19:54:52 -04:00
2018-05-06 21:51:37 -04:00
2017-12-15 12:34:00 -05:00
2018-03-23 11:31:58 -04:00
2018-05-10 15:13:33 -04:00
2018-04-09 10:10:55 +03:00
2018-04-26 15:08:04 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-05-06 21:51:37 -04:00
2017-11-02 11:10:55 +01:00
2018-03-27 09:51:23 +02:00
2016-08-17 19:36:23 -04:00
2016-10-13 12:05:26 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-10-25 12:06:25 +09:00
2018-04-22 14:55:03 -04:00
2017-07-04 22:35:15 +01:00
2018-02-14 14:43:32 -05:00
2018-03-29 16:23:26 -04:00
2016-07-08 13:23:12 +02:00
2017-11-02 11:10:55 +01:00
2017-04-01 20:21:44 -07:00
2016-10-03 02:00:22 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-04-25 13:19:59 -04:00
2018-03-29 13:47:53 -04:00
2017-11-02 11:10:55 +01:00
2018-03-04 13:04:23 -05:00
2017-07-01 07:39:09 -07:00
2017-11-02 11:10:55 +01:00
2015-12-08 22:02:33 -05:00
2017-11-02 11:10:55 +01:00
2018-04-07 22:32:31 -04:00
2016-07-08 12:20:57 +02:00
2017-11-08 16:12:33 +09:00
2017-11-02 11:10:55 +01:00
2018-04-17 10:50:29 -04:00
2016-03-23 22:09:58 -04:00
2018-02-28 12:06:01 -05:00
2018-01-16 14:56:54 -05:00
2017-11-02 11:10:55 +01:00
2017-10-01 03:55:47 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-07 11:39:21 -07:00
2017-11-02 11:10:55 +01:00
2017-12-05 14:37:13 -05:00
2018-03-29 11:11:40 +02:00
2017-10-20 13:21:36 +01:00
2017-11-02 11:10:55 +01:00
2018-03-23 11:31:58 -04:00
2018-03-13 18:37:02 +02:00
2017-12-04 11:32:53 -05:00
2018-04-01 19:49:34 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2016-11-09 20:40:06 -05:00
2017-08-25 17:10:23 -07:00
2018-04-11 10:33:46 -04:00
2017-11-02 11:10:55 +01:00
2016-04-28 11:49:45 -04:00
2017-11-02 11:10:55 +01:00
2018-05-10 15:13:34 -04:00
2018-03-01 21:21:36 -05:00
2017-11-02 11:10:55 +01:00
2017-10-25 10:37:11 +09:00
2018-05-03 13:46:47 -04:00
2018-02-21 15:06:05 -05:00
2018-05-01 09:42:46 -04:00
2015-07-09 15:12:20 -07:00
2018-05-08 00:02:41 -04:00
2018-05-04 09:58:56 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-29 15:16:52 -07:00
2017-11-02 11:10:55 +01:00
2018-05-08 22:30:06 -04:00
2018-02-16 15:57:42 -05:00
2018-04-17 13:53:13 -04:00
2018-01-24 19:13:45 -05:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-05-03 15:55:24 -07:00
2018-05-03 15:55:24 -07:00
2018-03-30 10:59:23 -04:00
0048369055