mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-12-27 14:41:22 -05:00
834ebb5678
Simplify the build ID reading code by removing the non-blocking option. Having to pass the correct option to this function was fragile and a mistake would result in a hang, see the linked fix. Furthermore, compressed files are always opened blocking anyway, ignoring the non-blocking option. We also don't expect to read build IDs from non-regular files. The only hits to this function that are non-regular are devices that won't be elf files with build IDs, for example "/dev/dri/renderD129". Now instead of opening these as non-blocking and failing to read, we skip them. Even if something like a pipe or character device did have a build ID, I don't think it would have worked because you need to call read() in a loop, check for -EAGAIN and handle timeouts to make non-blocking reads work. Link: https://lore.kernel.org/linux-perf-users/20251022-james-perf-fix-dso-block-v1-1-c4faab150546@linaro.org/ Signed-off-by: James Clark <james.clark@linaro.org> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
83 lines
2.1 KiB
C
83 lines
2.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __PERF_LIBBFD_H
|
|
#define __PERF_LIBBFD_H
|
|
|
|
#include <linux/compiler.h>
|
|
#include <linux/types.h>
|
|
#include <stdbool.h>
|
|
#include <stddef.h>
|
|
|
|
struct annotate_args;
|
|
struct build_id;
|
|
struct dso;
|
|
struct inline_node;
|
|
struct symbol;
|
|
|
|
#ifdef HAVE_LIBBFD_SUPPORT
|
|
int libbfd__addr2line(const char *dso_name, u64 addr,
|
|
char **file, unsigned int *line, struct dso *dso,
|
|
bool unwind_inlines, struct inline_node *node,
|
|
struct symbol *sym);
|
|
|
|
|
|
void dso__free_a2l_libbfd(struct dso *dso);
|
|
|
|
int symbol__disassemble_libbfd(const char *filename, struct symbol *sym,
|
|
struct annotate_args *args);
|
|
|
|
int libbfd__read_build_id(const char *filename, struct build_id *bid);
|
|
|
|
int libbfd_filename__read_debuglink(const char *filename, char *debuglink, size_t size);
|
|
|
|
int symbol__disassemble_bpf_libbfd(struct symbol *sym, struct annotate_args *args);
|
|
|
|
#else // !defined(HAVE_LIBBFD_SUPPORT)
|
|
#include "annotate.h"
|
|
|
|
static inline int libbfd__addr2line(const char *dso_name __always_unused,
|
|
u64 addr __always_unused,
|
|
char **file __always_unused,
|
|
unsigned int *line __always_unused,
|
|
struct dso *dso __always_unused,
|
|
bool unwind_inlines __always_unused,
|
|
struct inline_node *node __always_unused,
|
|
struct symbol *sym __always_unused)
|
|
{
|
|
return -1;
|
|
}
|
|
|
|
|
|
static inline void dso__free_a2l_libbfd(struct dso *dso __always_unused)
|
|
{
|
|
}
|
|
|
|
static inline int symbol__disassemble_libbfd(const char *filename __always_unused,
|
|
struct symbol *sym __always_unused,
|
|
struct annotate_args *args __always_unused)
|
|
{
|
|
return -1;
|
|
}
|
|
|
|
static inline int libbfd__read_build_id(const char *filename __always_unused,
|
|
struct build_id *bid __always_unused)
|
|
{
|
|
return -1;
|
|
}
|
|
|
|
static inline int libbfd_filename__read_debuglink(const char *filename __always_unused,
|
|
char *debuglink __always_unused,
|
|
size_t size __always_unused)
|
|
{
|
|
return -1;
|
|
}
|
|
|
|
static inline int symbol__disassemble_bpf_libbfd(struct symbol *sym __always_unused,
|
|
struct annotate_args *args __always_unused)
|
|
{
|
|
return SYMBOL_ANNOTATE_ERRNO__NO_LIBOPCODES_FOR_BPF;
|
|
}
|
|
|
|
#endif // defined(HAVE_LIBBFD_SUPPORT)
|
|
|
|
#endif /* __PERF_LIBBFD_H */
|