mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-05-16 07:51:31 -04:00
8a44bd3ffd
In all cases in which a struct acpi_driver is used for binding a driver to an ACPI device object, a corresponding platform device is created by the ACPI core and that device is regarded as a proper representation of underlying hardware. Accordingly, a struct platform_driver should be used by driver code to bind to that device. There are multiple reasons why drivers should not bind directly to ACPI device objects [1]. Overall, it is better to bind drivers to platform devices than to their ACPI companions, so convert the Intel Smart Connect disabling ACPI driver to a platform one. While this is not expected to alter functionality, it changes sysfs layout and so it will be visible to user space. Link: https://lore.kernel.org/all/2396510.ElGaqSPkdT@rafael.j.wysocki/ [1] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://patch.msgid.link/24282289.6Emhk5qWAg@rafael.j.wysocki Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
46 lines
1.0 KiB
C
46 lines
1.0 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright 2013 Matthew Garrett <mjg59@srcf.ucam.org>
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
MODULE_DESCRIPTION("Intel Smart Connect disabling driver");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
static int smartconnect_acpi_probe(struct platform_device *pdev)
|
|
{
|
|
acpi_handle handle = ACPI_HANDLE(&pdev->dev);
|
|
unsigned long long value;
|
|
acpi_status status;
|
|
|
|
status = acpi_evaluate_integer(handle, "GAOS", NULL, &value);
|
|
if (ACPI_FAILURE(status))
|
|
return -EINVAL;
|
|
|
|
if (value & 0x1) {
|
|
dev_info(&pdev->dev, "Disabling Intel Smart Connect\n");
|
|
status = acpi_execute_simple_method(handle, "SAOS", 0);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct acpi_device_id smartconnect_ids[] = {
|
|
{"INT33A0", 0},
|
|
{"", 0}
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, smartconnect_ids);
|
|
|
|
static struct platform_driver smartconnect_driver = {
|
|
.probe = smartconnect_acpi_probe,
|
|
.driver = {
|
|
.name = "intel_smart_connect",
|
|
.acpi_match_table = smartconnect_ids,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(smartconnect_driver);
|