mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-12-27 10:01:39 -05:00
1e3e330c07
The IRQCHIP_PLATFORM_DRIVER macros can be used to convert OF irqchip drivers to platform drivers but currently reuse the OF init callback prototype that only takes OF nodes as arguments. This forces drivers to do reverse lookups of their struct devices during probe if they need them for things like dev_printk() and device managed resources. Half of the drivers doing reverse lookups also currently fail to release the additional reference taken during the lookup, while other drivers have had the reference leak plugged in various ways (e.g. using non-intuitive cleanup constructs which still confuse static checkers). Switch to using a probe callback that takes a platform device as its first argument to simplify drivers and plug the remaining (mostly benign) reference leaks. Fixes:32c6c05466("irqchip: Add Broadcom BCM2712 MSI-X interrupt controller") Fixes:70afdab904("irqchip: Add IMX MU MSI controller driver") Fixes:a6199bb514("irqchip: Add Qualcomm MPM controller driver") Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
61 lines
1.8 KiB
C
61 lines
1.8 KiB
C
/*
|
|
* Copyright (C) 2012 Thomas Petazzoni
|
|
*
|
|
* Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
|
|
*
|
|
* This file is licensed under the terms of the GNU General Public
|
|
* License version 2. This program is licensed "as is" without any
|
|
* warranty of any kind, whether express or implied.
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/init.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_irq.h>
|
|
#include <linux/irqchip.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
/*
|
|
* This special of_device_id is the sentinel at the end of the
|
|
* of_device_id[] array of all irqchips. It is automatically placed at
|
|
* the end of the array by the linker, thanks to being part of a
|
|
* special section.
|
|
*/
|
|
static const struct of_device_id
|
|
irqchip_of_match_end __used __section("__irqchip_of_table_end");
|
|
|
|
extern struct of_device_id __irqchip_of_table[];
|
|
|
|
void __init irqchip_init(void)
|
|
{
|
|
of_irq_init(__irqchip_of_table);
|
|
acpi_probe_device_table(irqchip);
|
|
}
|
|
|
|
int platform_irqchip_probe(struct platform_device *pdev)
|
|
{
|
|
struct device_node *np = pdev->dev.of_node;
|
|
struct device_node *par_np __free(device_node) = of_irq_find_parent(np);
|
|
platform_irq_probe_t irq_probe = of_device_get_match_data(&pdev->dev);
|
|
|
|
if (!irq_probe)
|
|
return -EINVAL;
|
|
|
|
if (par_np == np)
|
|
par_np = NULL;
|
|
|
|
/*
|
|
* If there's a parent interrupt controller and none of the parent irq
|
|
* domains have been registered, that means the parent interrupt
|
|
* controller has not been initialized yet. it's not time for this
|
|
* interrupt controller to initialize. So, defer probe of this
|
|
* interrupt controller. The actual initialization callback of this
|
|
* interrupt controller can check for specific domains as necessary.
|
|
*/
|
|
if (par_np && !irq_find_matching_host(par_np, DOMAIN_BUS_ANY))
|
|
return -EPROBE_DEFER;
|
|
|
|
return irq_probe(pdev, par_np);
|
|
}
|
|
EXPORT_SYMBOL_GPL(platform_irqchip_probe);
|