mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2025-12-27 12:21:22 -05:00
607f2c00c6
Refactor the zl3073x driver by splitting the logic for input
references, outputs and synthesizers out of the monolithic
core.[ch] files.
Move the logic for each functional block into its own dedicated files:
ref.[ch], out.[ch] and synth.[ch].
Specifically:
- Move state structures (zl3073x_ref, zl3073x_out, zl3073x_synth)
from core.h into their respective new headers
- Move state-fetching functions (..._state_fetch) from core.c to their
new .c files
- Move the zl3073x_ref_freq_factorize helper from core.c to ref.c
- Introduce a new helper layer to decouple the core device logic from
the state-parsing logic:
1. Move the original inline helpers (e.g., zl3073x_ref_is_enabled)
to the new headers (ref.h, etc.) and make them operate on a
const struct ... * pointer.
2. Create new zl3073x_dev_... prefixed functions in core.h
(e.g., zl3073x_dev_ref_is_enabled) and Implement these _dev_ functions
to fetch state using a new ..._state_get() helper and then call
the non-prefixed helper.
3. Update all driver-internal callers (in dpll.c, prop.c, etc.) to use
the new zl3073x_dev_... functions.
Reviewed-by: Petr Oros <poros@redhat.com>
Tested-by: Prathosh Satish <Prathosh.Satish@microchip.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Link: https://patch.msgid.link/20251113074105.141379-3-ivecera@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
88 lines
2.1 KiB
C
88 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
|
|
#include <linux/bitfield.h>
|
|
#include <linux/cleanup.h>
|
|
#include <linux/dev_printk.h>
|
|
#include <linux/string.h>
|
|
#include <linux/string_choices.h>
|
|
#include <linux/types.h>
|
|
|
|
#include "core.h"
|
|
#include "synth.h"
|
|
|
|
/**
|
|
* zl3073x_synth_state_fetch - fetch synth state from hardware
|
|
* @zldev: pointer to zl3073x_dev structure
|
|
* @index: synth index to fetch state for
|
|
*
|
|
* Function fetches state of the given synthesizer from the hardware and
|
|
* stores it for later use.
|
|
*
|
|
* Return: 0 on success, <0 on error
|
|
*/
|
|
int zl3073x_synth_state_fetch(struct zl3073x_dev *zldev, u8 index)
|
|
{
|
|
struct zl3073x_synth *synth = &zldev->synth[index];
|
|
int rc;
|
|
|
|
/* Read synth control register */
|
|
rc = zl3073x_read_u8(zldev, ZL_REG_SYNTH_CTRL(index), &synth->ctrl);
|
|
if (rc)
|
|
return rc;
|
|
|
|
guard(mutex)(&zldev->multiop_lock);
|
|
|
|
/* Read synth configuration */
|
|
rc = zl3073x_mb_op(zldev, ZL_REG_SYNTH_MB_SEM, ZL_SYNTH_MB_SEM_RD,
|
|
ZL_REG_SYNTH_MB_MASK, BIT(index));
|
|
if (rc)
|
|
return rc;
|
|
|
|
/* The output frequency is determined by the following formula:
|
|
* base * multiplier * numerator / denominator
|
|
*
|
|
* Read registers with these values
|
|
*/
|
|
rc = zl3073x_read_u16(zldev, ZL_REG_SYNTH_FREQ_BASE, &synth->freq_base);
|
|
if (rc)
|
|
return rc;
|
|
|
|
rc = zl3073x_read_u32(zldev, ZL_REG_SYNTH_FREQ_MULT, &synth->freq_mult);
|
|
if (rc)
|
|
return rc;
|
|
|
|
rc = zl3073x_read_u16(zldev, ZL_REG_SYNTH_FREQ_M, &synth->freq_m);
|
|
if (rc)
|
|
return rc;
|
|
|
|
rc = zl3073x_read_u16(zldev, ZL_REG_SYNTH_FREQ_N, &synth->freq_n);
|
|
if (rc)
|
|
return rc;
|
|
|
|
/* Check denominator for zero to avoid div by 0 */
|
|
if (!synth->freq_n) {
|
|
dev_err(zldev->dev,
|
|
"Zero divisor for SYNTH%u retrieved from device\n",
|
|
index);
|
|
return -EINVAL;
|
|
}
|
|
|
|
dev_dbg(zldev->dev, "SYNTH%u frequency: %u Hz\n", index,
|
|
zl3073x_synth_freq_get(synth));
|
|
|
|
return rc;
|
|
}
|
|
|
|
/**
|
|
* zl3073x_synth_state_get - get current synth state
|
|
* @zldev: pointer to zl3073x_dev structure
|
|
* @index: synth index to get state for
|
|
*
|
|
* Return: pointer to given synth state
|
|
*/
|
|
const struct zl3073x_synth *zl3073x_synth_state_get(struct zl3073x_dev *zldev,
|
|
u8 index)
|
|
{
|
|
return &zldev->synth[index];
|
|
}
|