Thomas Zimmermann
1df5aa3754
backlight: sky81452-backlight: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-18-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
22f8a85ef0
backlight: rave-sp-backlight: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-17-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
eb1c4b6ddd
backlight: pwm-backlight: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-16-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
eca6b3ddfc
backlight: pcf50633-backlight: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-15-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
d4db2f1934
backlight: pandora-backlight: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-14-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
c2d9c4934b
backlight: mp3309c: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-13-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
761c83910b
backlight: lm3533-backlight: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-12-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
814d3e8200
backlight: led-backlight: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-11-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
def5831f09
backlight: ktd253-backlight: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-10-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
cebc25971f
backlight: kb3886-bl: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-9-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
6910d19bb8
backlight: journada_bl: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-8-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
b6675c5947
backlight: ipaq-micro-backlight: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Linus Walleij <linus.walleij@linaro.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-7-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
ef51815c5f
backlight: gpio-backlight: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Linus Walleij <linus.walleij@linaro.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-6-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
e263c05191
backlight: corgi-lcd: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Only change the driver's backlight device, but leave the LCD
device as-is.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-5-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
1adf98242e
backlight: ams369fb06: Use backlight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-4-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Thomas Zimmermann
26dcf62333
backlight: aat2870-backlight: Use blacklight power constants
...
Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240624152033.25016-3-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-07-04 16:45:25 +01:00
Javier Carrasco
b337cc3ce4
backlight: lm3509_bl: Fix early returns in for_each_child_of_node()
...
The for_each_child_of_node() macro automatically decrements the child
refcount at the end of every iteration. On early exits, of_node_put()
must be used to manually decrement the refcount and avoid memory leaks.
The scoped version of the macro accounts for such early breaks, fixing
the early exits without the need for explicit calls to of_node_put().
Reported-by: kernel test robot <lkp@intel.com >
Reported-by: Julia Lawall <julia.lawall@inria.fr >
Closes: https://lore.kernel.org/r/202406172314.2vVgelaS-lkp@intel.com/
Fixes: b72755f5b5 ("backlight: Add new lm3509 backlight driver")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com >
Link: https://lore.kernel.org/r/20240624-lm3509_bl_scoped-v1-1-ceba9df38f23@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org >
2024-06-26 16:49:59 +01:00
Uwe Kleine-König
bfd3587760
backlight: Drop explicit initialization of struct i2c_device_id::driver_data to 0
...
These drivers don't use the driver_data member of struct i2c_device_id,
so don't explicitly initialize this member.
This prepares putting driver_data in an anonymous union which requires
either no initialization or named designators. But it's also a nice
cleanup on its own.
While add it, also remove commas after the sentinel entries.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com >
Link: https://lore.kernel.org/r/20240619193558.2543645-2-u.kleine-koenig@baylibre.com
Signed-off-by: Lee Jones <lee@kernel.org >
2024-06-20 18:36:25 +01:00
Jeff Johnson
7857f5c38d
backlight: Add missing MODULE_DESCRIPTION() macros
...
With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/backlight/platform_lcd.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/video/backlight/rt4831-backlight.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com >
Link: https://lore.kernel.org/r/20240612-md-drivers-video-backlight-v1-1-f4ca1beb36cc@quicinc.com
Signed-off-by: Lee Jones <lee@kernel.org >
2024-06-13 18:19:48 +01:00
Dan Carpenter
90b7f2ead9
backlight: lm3509_bl: Fix NULL vs IS_ERR() check in register() function
...
The devm_backlight_device_register() doesn't return NULL, it returns
error pointers. Update the error checking to match.
Fixes: b72755f5b5 ("backlight: Add new lm3509 backlight driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/187b5bc5-a010-46c2-8ead-980df9efae79@moroto.mountain
Signed-off-by: Lee Jones <lee@kernel.org >
2024-06-13 17:45:23 +01:00
Patrick Gansterer
b72755f5b5
backlight: Add new lm3509 backlight driver
...
This is a general driver for LM3509 backlight chip of TI.
LM3509 is High Efficiency Boost for White LEDs and/or OLED Displays with
Dual Current Sinks. This driver supports OLED/White LED select, brightness
control and sub/main control.
The datasheet can be found at http://www.ti.com/product/lm3509 .
Signed-off-by: Patrick Gansterer <paroga@paroga.com >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240526105136.721529-3-paroga@paroga.com
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-31 15:12:13 +01:00
Shresth Prasad
1fd949f653
backlight: sky81452-backlight: Remove unnecessary call to of_node_get()
...
`dev->of_node` already has a reference to the device_node and calling
of_node_get on it is unnecessary. All conresponding calls to
of_node_put are also removed.
Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240502172121.8695-2-shresthprasad7@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-10 15:44:29 +01:00
Flavio Suligoi
f80460c523
backlight: mp3309c: Fix LEDs flickering in PWM mode
...
The mp3309 has two configuration registers, named according to their
address (0x00 and 0x01).
In the second register (0x01), the bit DIMS (Dimming Mode Select) must
be always 0 (zero), in both analog (via I2C commands) and PWM dimming
mode.
In the initial driver version, the DIMS bit was set in PWM mode and
reset in analog mode.
But if the DIMS bit is set in pwm dimming mode and other devices are
connected on the same I2C bus, every I2C commands on the bus generates a
flickering on the LEDs powered by the mp3309c.
This change concerns the chip initialization and does not impact any
existing device-tree configuration.
Signed-off-by: Flavio Suligoi <f.suligoi@asem.it >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240417153105.1794134-2-f.suligoi@asem.it
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-10 15:44:29 +01:00
Krzysztof Kozlowski
89c26f9ad3
backlight: otm3225a: Drop driver owner assignment
...
Core in spi_register_driver() already sets the .owner, so driver
does not need to.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240327174714.519577-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-10 15:44:29 +01:00
Uwe Kleine-König
b303ab78f8
backlight: lp8788: Drop support for platform data
...
The backlight driver supports getting passed platform data. However this
isn't used. This allows to remove quite some dead code from the driver
because bl->pdata is always NULL, and so bl->mode is always
LP8788_BL_REGISTER_ONLY.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240329133839.550065-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-10 15:44:28 +01:00
Ricardo B. Marliere
717bbf03d2
backlight: lcd: Make lcd_class constant
...
Since commit 43a7206b09 ("driver core: class: make class_register() take
a const *"), the driver core allows for struct class to be in read-only
memory, so move the lcd_class structure to be declared at build time
placing it into read-only memory, instead of having to be dynamically
allocated at boot time.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/2024032809-enchanted-conducive-3677@gregkh
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-10 15:44:28 +01:00
Ricardo B. Marliere
cda12ba555
backlight: Make backlight_class constant
...
Since commit 43a7206b09 ("driver core: class: make class_register() take
a const *"), the driver core allows for struct class to be in read-only
memory, so move the backlight_class structure to be declared at build time
placing it into read-only memory, instead of having to be dynamically
allocated at boot time.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240305-class_cleanup-backlight-v1-1-c0e15cc25be1@marliere.net
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-10 15:44:28 +01:00
Dan Carpenter
e962f13b1e
backlight: mp3309c: Fix signedness bug in mp3309c_parse_fwnode()
...
The "num_levels" variable is used to store error codes from
device_property_count_u32() so it needs to be signed. This doesn't
cause an issue at runtime because devm_kcalloc() won't allocate negative
sizes. However, it's still worth fixing.
Fixes: b54c828bdb ("backlight: mp3309c: Make use of device properties")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Tested-by: Flavio Suligoi <f.suligoi@asem.it >
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/74347f67-360d-4513-8939-595e3c4764fa@moroto.mountain
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-10 15:44:28 +01:00
Lee Jones
13cb61bed5
Merge branches 'ib-backlight-auxdisplay-staging-omap-6.9', 'ib-backlight-auxdisplay-hid-fb-6.9' and 'ib-backlight-hid-fbdev-lcd-scripts-6.10' into ibs-for-backlight-merged
2024-05-10 15:43:31 +01:00
Krzysztof Kozlowski
ee7b1e8465
backlight: tdo24m: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-14-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:45:31 +01:00
Krzysztof Kozlowski
02bc4c447e
backlight: platform_lcd: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-13-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:45:28 +01:00
Krzysztof Kozlowski
c935555c8a
backlight: otm3225a: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-12-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:45:25 +01:00
Krzysztof Kozlowski
62560bfafd
backlight: ltv350qv: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-11-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:45:22 +01:00
Krzysztof Kozlowski
2b472876a4
backlight: lms501kf03: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-10-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:45:19 +01:00
Krzysztof Kozlowski
7ae6431a10
backlight: lms283gf05: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-9-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:45:16 +01:00
Krzysztof Kozlowski
aefc911e42
backlight: l4f00242t03: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-8-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:45:13 +01:00
Krzysztof Kozlowski
26679a7017
backlight: jornada720_lcd: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-7-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:45:09 +01:00
Krzysztof Kozlowski
a2b3af58ce
backlight: ili9320: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-6-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:45:06 +01:00
Krzysztof Kozlowski
c4643239dc
backlight: ili922x: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-5-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:45:03 +01:00
Krzysztof Kozlowski
4c00ff8ebf
backlight: hx8357: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-4-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:44:59 +01:00
Krzysztof Kozlowski
94194e314e
backlight: corgi_lcd: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-3-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:44:56 +01:00
Krzysztof Kozlowski
03788e747f
backlight: ams369fg06: Constify lcd_ops
...
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-2-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:44:51 +01:00
Krzysztof Kozlowski
a2e25c8165
backlight: lcd: Constify lcd_ops
...
'struct lcd_ops' passed in lcd_device_register() is not modified by core
backlight code, so it can be made const for code safety. This allows
drivers to also define the structure as const.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-1-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org >
2024-05-03 10:44:42 +01:00
Thomas Zimmermann
4551978bb5
backlight: Remove fb_blank from struct backlight_properties
...
Remove the field fb_blank from struct backlight_properties and remove
all code that still sets or reads it. Backlight blank status is now
tracked exclusively in struct backlight_properties.state.
The core backlight code keeps the fb_blank and state fields in sync,
but doesn't do anything else with fb_blank. Several drivers initialize
fb_blank to FB_BLANK_UNBLANK to enable the backlight. This is already
the default for the state field. So we can delete the fb_blank code
from core and drivers and rely on the state field.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Cc: Flavio Suligoi <f.suligoi@asem.it >
Cc: Nicolas Ferre <nicolas.ferre@microchip.com >
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com >
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev >
Tested-by: Flavio Suligoi <f.suligoi@asem.it >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org >
Link: https://lore.kernel.org/r/20240319093915.31778-7-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-03-28 10:16:26 +00:00
Thomas Zimmermann
bf8c955044
backlight: omap1: Replace FB_BLANK_ states with simple on/off
...
The backlight is on for fb_blank eq FB_BLANK_UNBLANK, or off for
any other value in fb_blank. But the field fb_blank in struct
backlight_properties is deprecated and should not be used any
longer.
Replace the test for fb_blank in omap's backlight code with a
simple boolean parameter and push the test into the update_status
helper. Instead of reading fb_blank directly, decode the backlight
device's status with backlight_is_blank().
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Link: https://lore.kernel.org/r/20240319093915.31778-4-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-03-28 10:12:52 +00:00
Thomas Zimmermann
b7ad4c67ed
backlight: omap1: Remove unused struct omap_backlight_config.set_power
...
The callback set_power in struct omap_backlight_config is not
implemented anywhere. Remove it from the structure and driver.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Sam Ravnborg <sam@ravnborg.org >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org >
Link: https://lore.kernel.org/r/20240319093915.31778-3-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-03-28 10:12:49 +00:00
Thomas Zimmermann
0a4be72637
backlight: Add controls_device callback to struct backlight_ops
...
Replace check_fb with controls_device in struct backlight_ops. The
new callback interface takes a Linux device instead of a framebuffer.
Resolves one of the dependencies of backlight.h on fb.h.
The few drivers that had custom implementations of check_fb can easily
use the framebuffer's Linux device instead. Update them accordingly.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com >
Link: https://lore.kernel.org/r/20240305162425.23845-11-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-03-28 10:09:06 +00:00
Thomas Zimmermann
397b749372
backlight: pwm-backlight: Remove struct backlight_ops.check_fb
...
The internal check_fb callback from struct pwm_bl_data is never
implemented. The driver's implementation of check_fb always
returns true, which is the backlight core's default if no
implementation has been set. So remove the code from the driver.
v2:
* reword commit message
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com >
Link: https://lore.kernel.org/r/20240305162425.23845-7-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-03-28 10:09:02 +00:00
Thomas Zimmermann
0133952aac
backlight: aat2870-backlight: Remove struct backlight.check_fb
...
The driver's implementation of check_fb always returns true, which
is the default if no implementation has been set. So remove the code
from the driver.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com >
Link: https://lore.kernel.org/r/20240305162425.23845-6-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-03-28 10:09:01 +00:00
Thomas Zimmermann
e6c6fea5c3
backlight: Match backlight device against struct fb_info.bl_dev
...
Framebuffer drivers for devices with dedicated backlight are supposed
to set struct fb_info.bl_dev to the backlight's respective device. Use
the value to match backlight and framebuffer in the backlight core code.
The code first tests against struct backlight_ops.check_ops. If this
test succeeds, it performs the test against fbdev. So backlight drivers
can override the later test as before.
Fbdev's backlight support depends on CONFIG_FB_BACKLIGHT. To avoid
ifdef in the code, the new helper fb_bl_device() returns the backlight
device, or NULL if the config option has been disabled. The test in
the backlight code will then do nothing.
v4:
* declare empty fb_bl_device() as static inline
* export fb_bl_device()
v3:
* hide ifdef in fb_bl_device() (Lee)
* no if-else blocks (Andy)
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org >
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com >
Link: https://lore.kernel.org/r/20240305162425.23845-2-tzimmermann@suse.de
Signed-off-by: Lee Jones <lee@kernel.org >
2024-03-28 10:08:47 +00:00