David Thompson
7e38a7422f
mlxbf-bootctl: Support sysfs entries for MFG fields
...
This patch extends the mlxbf-bootctl driver's sysfs entries
to support read and write access for the manufacturing (MFG)
fields in the board-level EEPROM. The MFG fields are set
once during the board manufacturing phase, and then the MFG
fields are write-protected.
Signed-off-by: David Thompson <davthompson@nvidia.com >
Reviewed-by: Shravan Kumar Ramani <shravankr@nvidia.com >
Link: https://lore.kernel.org/r/20230821183939.3229-1-davthompson@nvidia.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-23 17:31:27 +02:00
Shyam Sundar S K
92c2fb8fa5
platform/x86/amd/pmc: Move PMC driver to separate directory
...
With latest commits having PMC code spread across multiple files, it would
be easier to maintain them in a separate directory under amd/pmc.
Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com >
Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com >
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com >
Link: https://lore.kernel.org/r/20230811112116.2279419-2-Shyam-sundar.S-k@amd.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-23 17:31:26 +02:00
Hans de Goede
b0c7f1d9d7
Merge remote-tracking branch 'pdx86/fixes' into pdx86/for-next
...
Merge pdx86/fixes into pdx86/for-next because there are some
pdx86 patches pending for the next release which build on top
of some of the fixes.
2023-08-23 17:30:50 +02:00
Shih-Yi Chen
0848cab765
platform/mellanox: Fix mlxbf-tmfifo not handling all virtio CONSOLE notifications
...
rshim console does not show all entries of dmesg.
Fixed by setting MLXBF_TM_TX_LWM_IRQ for every CONSOLE notification.
Signed-off-by: Shih-Yi Chen <shihyic@nvidia.com >
Reviewed-by: Liming Sung <limings@nvidia.com >
Reviewed-by: David Thompson <davthompson@nvidia.com >
Link: https://lore.kernel.org/r/20230821150627.26075-1-shihyic@nvidia.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-23 17:13:36 +02:00
Jorge Lopez
559eed7776
platform/x86: hp-bioscfg: Update steps order list elements are evaluated
...
Update steps how order list elements data and elements size are
evaluated.
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230821144205.13529-1-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-21 18:56:18 +02:00
Luke D. Jones
fa69653f87
platform/x86: asus-wmi: Fix support for showing middle fan RPM
...
After the addition of the mid fan custom curve functionality various
incorrect behaviour was uncovered. This commit fixes these areas.
- Ensure mid fan attributes actually use the correct fan ID
- Correction to a bit mask for selecting the correct fan data
- Refactor the curve show/store functions to be cleaner and
match each others layout
Fixes: 536fce82d7 ("platform/x86: asus-wmi: add support for showing middle fan RPM")
Signed-off-by: Luke D. Jones <luke@ljones.dev >
Link: https://lore.kernel.org/r/20230815014209.44903-1-luke@ljones.dev
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
2023-08-21 15:30:19 +02:00
Andy Shevchenko
cd99ebe5b3
platform/x86/amd/pmf: Use str_on_off() helper
...
We have a common helper to represent a boolean value as "on"/"off"
string. Use it for the sake of the unified style.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com >
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com >
Link: https://lore.kernel.org/r/20230811131330.71263-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-21 15:20:28 +02:00
Ruan Jinjie
4316c64085
platform/x86: thinkpad_acpi: Switch to memdup_user_nul() helper
...
Use memdup_user_nul() helper instead of open-coding to simplify the code.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com >
Link: https://lore.kernel.org/r/20230810122012.2110410-1-ruanjinjie@huawei.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-21 14:00:38 +02:00
André Apitzsch
a260f7d726
platform/x86: ideapad-laptop: Add support for new hotkeys found on ThinkBook 14s Yoga ITL
...
The Lenovo Thinkbook 14s Yoga ITL has 4 new symbols/shortcuts on their
F9-F11 and PrtSc keys:
F9: Has a symbol of a head with a headset, the manual says "Service key"
F10: Has a symbol of a telephone horn which has been picked up from the
receiver, the manual says: "Answer incoming calls"
F11: Has a symbol of a telephone horn which is resting on the receiver,
the manual says: "Reject incoming calls"
PrtSc: Has a symbol of a siccor and a dashed ellipse, the manual says:
"Open the Windows 'Snipping' Tool app"
This commit adds support for these 4 new hkey events.
Signed-off-by: André Apitzsch <git@apitzsch.eu >
Link: https://lore.kernel.org/r/20230819-lenovo_keys-v1-1-9d34eac88e0a@apitzsch.eu
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-21 13:09:38 +02:00
Swapnil Devesh
db35610a18
platform/x86: lenovo-ymc: Add Lenovo Yoga 7 14ACN6 to ec_trigger_quirk_dmi_table
...
This adds my laptop Lenovo Yoga 7 14ACN6, with Product Name: 82N7
(from `dmidecode -t1 | grep "Product Name"`) to
the ec_trigger_quirk_dmi_table, have tested that this is required
for the YMC driver to work correctly on this model.
Signed-off-by: Swapnil Devesh <me@sidevesh.com >
Reviewed-by: Gergő Köteles <soyer@irl.hu >
Link: https://lore.kernel.org/r/18a08a8b173.895ef3b250414.1213194126082324071@sidevesh.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-21 13:08:32 +02:00
Hans de Goede
65c6ea33e7
Merge remote-tracking branch 'pdx86/platform-drivers-x86-simatic-ipc' into review-hans
2023-08-14 16:37:19 +02:00
Ashok Raj
b0e67db12d
x86/microcode/intel: Rename get_datasize() since its used externally
...
Rename get_datasize() to intel_microcode_get_datasize() and make it an inline.
[ tglx: Make the argument typed and fix up the IFS code ]
Suggested-by: Boris Petkov <bp@alien8.de >
Signed-off-by: Ashok Raj <ashok.raj@intel.com >
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de >
Link: https://lore.kernel.org/r/20230812195727.894165745@linutronix.de
2023-08-13 18:42:55 +02:00
Ashok Raj
82ad097b02
x86/microcode: Include vendor headers into microcode.h
...
Currently vendor specific headers are included explicitly when used in
common code. Instead, include the vendor specific headers in
microcode.h, and include that in all usages.
No functional change.
Suggested-by: Boris Petkov <bp@alien8.de >
Signed-off-by: Ashok Raj <ashok.raj@intel.com >
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de >
Link: https://lore.kernel.org/r/20230812195727.776541545@linutronix.de
2023-08-13 18:42:55 +02:00
Hans de Goede
2b6aa6610d
platform/x86: lenovo-ymc: Only bind on machines with a convertible DMI chassis-type
...
The lenovo-ymc driver is causing the keyboard + touchpad to stop working
on some regular laptop models such as the Lenovo ThinkBook 13s G2 ITL 20V9.
The problem is that there are YMC WMI GUID methods in the ACPI tables
of these laptops, despite them not being Yogas and lenovo-ymc loading
causes libinput to see a SW_TABLET_MODE switch with state 1.
This in turn causes libinput to ignore events from the builtin keyboard
and touchpad, since it filters those out for a Yoga in tablet mode.
Similar issues with false-positive SW_TABLET_MODE=1 reporting have
been seen with the intel-hid driver.
Copy the intel-hid driver approach to fix this and only bind to the WMI
device on machines where the DMI chassis-type indicates the machine
is a convertible.
Add a 'force' module parameter to allow overriding the chassis-type check
so that users can easily test if the YMC interface works on models which
report an unexpected chassis-type.
Fixes: e82882cdd2 ("platform/x86: Add driver for Yoga Tablet Mode switch")
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2229373
Cc: André Apitzsch <git@apitzsch.eu >
Cc: stable@vger.kernel.org
Tested-by: Andrew Kallmeyer <kallmeyeras@gmail.com >
Tested-by: Gergő Köteles <soyer@irl.hu >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
Link: https://lore.kernel.org/r/20230812144818.383230-1-hdegoede@redhat.com
2023-08-13 14:50:25 +02:00
Vadim Pasternak
d66a8aab7d
platform: mellanox: Change register offset addresses
...
Move debug register offsets to different location due to hardware changes.
Fixes: dd635e33b5 ("platform: mellanox: Introduce support of new Nvidia L1 switch")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com >
Reviewed-by: Michael Shych <michaelsh@nvidia.com >
Link: https://lore.kernel.org/r/20230813083735.39090-5-vadimp@nvidia.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-13 14:49:46 +02:00
Vadim Pasternak
9f8ccdb508
platform: mellanox: mlx-platform: Modify graceful shutdown callback and power down mask
...
Use kernel_power_off() instead of kernel_halt() to pass through
machine_power_off() -> pm_power_off(), otherwise axillary power does
not go off.
Change "power down" bitmask.
Fixes: dd635e33b5 ("platform: mellanox: Introduce support of new Nvidia L1 switch")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com >
Reviewed-by: Michael Shych <michaelsh@nvidia.com >
Link: https://lore.kernel.org/r/20230813083735.39090-4-vadimp@nvidia.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-13 14:49:46 +02:00
Vadim Pasternak
3c91d7e8c6
platform: mellanox: mlx-platform: Fix signals polarity and latch mask
...
Change polarity of chassis health and power signals and fix latch reset
mask for L1 switch.
Fixes: dd635e33b5 ("platform: mellanox: Introduce support of new Nvidia L1 switch")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com >
Reviewed-by: Michael Shych <michaelsh@nvidia.com >
Link: https://lore.kernel.org/r/20230813083735.39090-3-vadimp@nvidia.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-13 14:49:46 +02:00
Vadim Pasternak
8e3938cff0
platform: mellanox: Fix order in exit flow
...
Fix exit flow order: call mlxplat_post_exit() after
mlxplat_i2c_main_exit() in order to unregister main i2c driver before
to "mlxplat" driver.
Fixes: 0170f616f4 ("platform: mellanox: Split initialization procedure")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com >
Reviewed-by: Michael Shych <michaelsh@nvidia.com >
Link: https://lore.kernel.org/r/20230813083735.39090-2-vadimp@nvidia.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-13 14:49:46 +02:00
Asmaa Mnebhi
e3205d4173
mlxbf-bootctl: Support setting the ARM boot state to "OS up"
...
The BlueField has internal registers to store the ARM boot states.
Support setting the BlueField ARM boot state to "OS up".
Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com >
Reviewed-by: Vadim Pasternak <vadimp@nvidia.com >
Link: https://lore.kernel.org/r/20230809162857.21243-3-asmaa@nvidia.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-10 11:12:47 +02:00
Asmaa Mnebhi
b18a97ed90
mlxbf-bootctl: Support the large icmc write/read
...
Enable reading and writing the size of the memory region associated
with the large ICM carveout.
The max size of the large ICM carveout is 1TB, has a granularity
of 128MB and will be passed and printed in hex. The size unit is MB.
Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com >
Reviewed-by: Vadim Pasternak <vadimp@nvidia.com >
Link: https://lore.kernel.org/r/20230809162857.21243-2-asmaa@nvidia.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-10 11:12:46 +02:00
xingtong.wu
7abf253afa
platform/x86/siemens: simatic-ipc-batt: fix logical error for BX-59A
...
The variable "priv.devmode" is missing from if statement that leads
to a logical error. Add the missing variable to the if condition.
Fixes: c56beff203 ("platform/x86/siemens: simatic-ipc-batt: add support for module BX-59A")
Reported-by: kernel test robot <lkp@intel.com >
Closes: https://lore.kernel.org/oe-kbuild-all/202308010001.BGYCSQrl-lkp@intel.com/
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com >
Signed-off-by: xingtong.wu <xingtong.wu@siemens.com >
Link: https://lore.kernel.org/r/20430802173844.2483-1-xingtong_wu@163.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-10 10:46:13 +02:00
xingtong.wu
b01c1e022f
platform/x86/siemens: simatic-ipc: fix logical error for BX-59A
...
The variable "ledmode" is missing from if statement that leads to
a logical error. Add the missing variable to the if condition.
Fixes: b8af779519 ("platform/x86/siemens: simatic-ipc: add new models BX-56A/BX-59A")
Reported-by: kernel test robot <lkp@intel.com >
Closes: https://lore.kernel.org/oe-kbuild-all/202307312322.Aa8upHWK-lkp@intel.com/
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com >
Signed-off-by: xingtong.wu <xingtong.wu@siemens.com >
Link: https://lore.kernel.org/r/20430802173515.2363-2-xingtong_wu@163.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-10 10:42:11 +02:00
Tzung-Bi Shih
0820debb7d
platform/chrome: chromeos_acpi: print hex string for ACPI_TYPE_BUFFER
...
`element->buffer.pointer` should be binary blob. `%s` doesn't work
perfect for them.
Print hex string for ACPI_TYPE_BUFFER. Also update the documentation
to reflect this.
Fixes: 0a4cad9c11 ("platform/chrome: Add ChromeOS ACPI device driver")
Cc: stable@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net >
Link: https://lore.kernel.org/r/20230803011245.3773756-1-tzungbi@kernel.org
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org >
2023-08-10 11:10:56 +08:00
Yang Yingliang
e5d5ffa48a
platform/x86/siemens: simatic-ipc-batt: fix wrong pointer pass to PTR_ERR()
...
Fix wrong pointer pass to PTR_ERR() if devm_gpiod_get_index() fails.
Fixes: 917f543407 ("platform/x86: simatic-ipc: add CMOS battery monitoring")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com >
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com >
Link: https://lore.kernel.org/r/20230809081227.1221267-1-yangyingliang@huawei.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-09 22:02:50 +02:00
Srinivas Pandruvada
af8a6d281b
platform/x86: ISST: Reduce noise for missing numa information in logs
...
On platforms with no numa support and with several CPUs, logs have lots
of noise for message "Fail to get numa node for CPU:.."
Change pr_info() to pr_info_once() as one print is enough to show the
issue.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com >
Link: https://lore.kernel.org/r/20230808174359.50602-1-srinivas.pandruvada@linux.intel.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-09 22:00:17 +02:00
Jean Delvare
5a66d59b5f
platform/x86: msi-ec: Fix the build
...
The msi-ec driver fails to build for me (gcc 7.5):
CC [M] drivers/platform/x86/msi-ec.o
drivers/platform/x86/msi-ec.c:72:6: error: initializer element is not constant
{ SM_ECO_NAME, 0xc2 },
^~~~~~~~~~~
drivers/platform/x86/msi-ec.c:72:6: note: (near initialization for ‘CONF0.shift_mode.modes[0].name’)
drivers/platform/x86/msi-ec.c:73:6: error: initializer element is not constant
{ SM_COMFORT_NAME, 0xc1 },
^~~~~~~~~~~~~~~
drivers/platform/x86/msi-ec.c:73:6: note: (near initialization for ‘CONF0.shift_mode.modes[1].name’)
drivers/platform/x86/msi-ec.c:74:6: error: initializer element is not constant
{ SM_SPORT_NAME, 0xc0 },
^~~~~~~~~~~~~
drivers/platform/x86/msi-ec.c:74:6: note: (near initialization for ‘CONF0.shift_mode.modes[2].name’)
(...)
Don't try to be smart, just use defines for the constant strings. The
compiler will recognize it's the same string and will store it only
once in the data section anyway.
Signed-off-by: Jean Delvare <jdelvare@suse.de >
Fixes: 392cacf2aa ("platform/x86: Add new msi-ec driver")
Cc: stable@vger.kernel.org
Cc: Nikita Kravets <teackot@gmail.com >
Cc: Hans de Goede <hdegoede@redhat.com >
Cc: Mark Gross <markgross@kernel.org >
Link: https://lore.kernel.org/r/20230805101010.54d49e91@endymion.delvare
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-09 21:57:50 +02:00
Armin Wolf
7295a996fd
platform/x86: dell-sysman: Fix reference leak
...
If a duplicate attribute is found using kset_find_obj(),
a reference to that attribute is returned. This means
that we need to dispose it accordingly. Use kobject_put()
to dispose the duplicate attribute in such a case.
Compile-tested only.
Fixes: e8a60aa740 ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Signed-off-by: Armin Wolf <W_Armin@gmx.de >
Link: https://lore.kernel.org/r/20230805053610.7106-1-W_Armin@gmx.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-09 21:56:39 +02:00
Peter Zijlstra
0cfd8fbadd
x86/cpu: Fix Crestmont uarch
...
Sierra Forest and Grand Ridge are both E-core only using Crestmont
micro-architecture, They fit the pre-existing naming scheme prefectly
fine, adhere to it.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org >
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Acked-by: Hans de Goede <hdegoede@redhat.com >
Link: https://lore.kernel.org/r/20230807150405.757666627@infradead.org
2023-08-09 21:51:06 +02:00
Peter Zijlstra
882cdb06b6
x86/cpu: Fix Gracemont uarch
...
Alderlake N is an E-core only product using Gracemont
micro-architecture. It fits the pre-existing naming scheme perfectly
fine, adhere to it.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org >
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Acked-by: Hans de Goede <hdegoede@redhat.com >
Link: https://lore.kernel.org/r/20230807150405.686834933@infradead.org
2023-08-09 21:51:06 +02:00
Li Zetao
6f8972a02a
platform/x86: hp-bioscfg: Use kmemdup() to replace kmalloc + memcpy
...
There are some warnings reported by coccinelle:
./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:317:35-42:
WARNING opportunity for kmemdup
./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:270:40-47:
WARNING opportunity for kmemdup
./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:233:36-43:
WARNING opportunity for kmemdup
Use kmemdup rather than duplicating its implementation.
Signed-off-by: Li Zetao <lizetao1@huawei.com >
Reviewed-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230803032027.3044851-1-lizetao1@huawei.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:36:20 +02:00
Jorge Lopez
bfecbcb571
platform/x86: hp-bioscfg: Remove duplicate use of variable in inner loop
...
Replace use of same variable in inner loop.
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-9-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:35:32 +02:00
Jorge Lopez
efd4211e54
platform/x86: hp-bioscfg: Change how password encoding size is evaluated
...
Update steps how password encoding size is evaluated
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-8-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:35:30 +02:00
Jorge Lopez
42efc9e65d
platform/x86: hp-bioscfg: Change how enum possible values size is evaluated
...
Updates steps how enum possible values size is evaluated
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-7-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:35:28 +02:00
Jorge Lopez
24652a8c0e
platform/x86: hp-bioscfg: Change how order list size is evaluated
...
Update steps how order list size is evaluated
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-6-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:35:23 +02:00
Jorge Lopez
08f1f21257
platform/x86: hp-bioscfg: Change how prerequisites size is evaluated
...
Update steps taken to evaluate prerequisites size value
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-5-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:34:46 +02:00
Jorge Lopez
a585400b36
platform/x86: hp-bioscfg: Replace the word HACK from source code
...
Replace the word 'HACK' with 'step' from source code
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-4-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:34:42 +02:00
Jorge Lopez
80d7ba3020
platform/x86: hp-bioscfg: Fix uninitialized variable errors
...
Fix uninitialized variable errors.
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-3-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:34:38 +02:00
Jorge Lopez
467d416381
platform/x86: hp-bioscfg: Fix memory leaks in attribute packages
...
Address memory leaks while handling elements in packages.
Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com >
Link: https://lore.kernel.org/r/20230731203141.30044-2-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-08-07 13:34:30 +02:00
Tzung-Bi Shih
703e77134e
platform/chrome: chromeos_acpi: support official HID GOOG0016
...
Support official HID GOOG0016 for ChromeOS ACPI (see [1]).
[1]: https://crrev.com/c/2266713
Reviewed-by: Simon Glass <sjg@chromium.org >
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com >
Reviewed-by: Guenter Roeck <groeck@chromium.org >
Link: https://lore.kernel.org/r/20230731024214.908235-1-tzungbi@kernel.org
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org >
2023-08-07 11:00:02 +08:00
Rob Barnes
f2d4dced9a
platform/chrome: cros_ec_lpc: Remove EC panic shutdown timeout
...
Remove the 1 second timeout applied to hw_protection_shutdown after an
EC panic. On some platforms this 1 second timeout is insufficient to
allow the filesystem to fully sync. Independently the EC will force a
full system reset after a short period. So this backup timeout is
unnecessary.
Signed-off-by: Rob Barnes <robbarnes@google.com >
Reviewed-by: Guenter Roeck <groeck@chromium.org >
Link: https://lore.kernel.org/r/20230802175847.1.Ie9fc53b6a1f4c6661c5376286a50e0cf51b3e961@changeid
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org >
2023-08-07 10:39:16 +08:00
Armin Wolf
516b2754e8
platform/x86: wmi-bmof: Simplify read_bmof()
...
Replace offset handling code with a single call
to memory_read_from_buffer() to simplify read_bmof().
Tested on a ASUS PRIME B650-PLUS.
Reviewed-by: Thomas Weißschuh <linux@weissschuh.net >
Tested-by: Thomas Weißschuh <linux@weissschuh.net >
Signed-off-by: Armin Wolf <W_Armin@gmx.de >
Link: https://lore.kernel.org/r/20230730204550.3402-2-W_Armin@gmx.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-07-31 16:07:41 +02:00
Armin Wolf
f4ae2e96ae
platform/x86: wmi-bmof: Use device_create_bin_file()
...
Use device_create_bin_file() instead of sysfs_create_bin_file()
to avoid having to access the device kobject.
Tested on a ASUS PRIME B650-PLUS.
Reviewed-by: Thomas Weißschuh <linux@weissschuh.net >
Tested-by: Thomas Weißschuh <linux@weissschuh.net >
Signed-off-by: Armin Wolf <W_Armin@gmx.de >
Link: https://lore.kernel.org/r/20230730204550.3402-1-W_Armin@gmx.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-07-31 16:07:24 +02:00
Hans de Goede
17ffe3a0fd
Merge tag 'ib-pdx86-simatic-v6.6-2' into review-hans
...
Immutable branch between pdx86 simatic branch and LED due for the v6.6 merge window
ib-pdx86-simatic-v6.6-2: v6.5-rc1 + ib-pdx86-simatic-v6.6 +
more recent pdx86 simatic-ipc patches for merging into
the LED subsystem for v6.6.
2023-07-31 16:05:44 +02:00
Simon Trimmer
1cd0302be5
ACPI: scan: Create platform device for CS35L56
...
The ACPI device CSC3556 is a Cirrus Logic CS35L56 mono amplifier which
is used in multiples, and can be connected either to I2C or SPI.
There will be multiple instances under the same Device() node. Add it
to ignore_serial_bus_ids and handle it in the serial-multi-instantiate
driver.
There can be a 5th I2cSerialBusV2, but this is an alias address and doesn't
represent a real device. Ignore this by having a dummy 5th entry in the
serial-multi-instantiate instance list with the name of a non-existent
driver, on the same pattern as done for bsg2150.
Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com >
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com >
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Link: https://lore.kernel.org/r/20230728111345.7224-1-rf@opensource.cirrus.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-07-31 16:03:39 +02:00
Yang Li
785c00993d
platform/x86/amd/pmf: Fix unsigned comparison with less than zero
...
The return value from the call to amd_pmf_get_pprof_modes() is int.
However, the return value is being assigned to an unsigned char
variable 'mode', so making 'mode' an int.
silence the warning:
./drivers/platform/x86/amd/pmf/sps.c:183:5-9: WARNING: Unsigned expression compared with zero: mode < 0
Reported-by: Abaci Robot <abaci@linux.alibaba.com >
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5995
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com >
Link: https://lore.kernel.org/r/20230727014315.51375-1-yang.lee@linux.alibaba.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-07-31 16:01:58 +02:00
xingtong.wu
c56beff203
platform/x86/siemens: simatic-ipc-batt: add support for module BX-59A
...
This is used for the Siemens Simatic IPC BX-59A, which
can monitor the voltage of the CMOS battery with two bits
that indicate low or empty state
Signed-off-by: xingtong.wu <xingtong.wu@siemens.com >
Link: https://lore.kernel.org/r/20230731072148.4781-1-xingtong_wu@163.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-07-31 14:24:44 +02:00
xingtong.wu
b8af779519
platform/x86/siemens: simatic-ipc: add new models BX-56A/BX-59A
...
This adds support for the Siemens Simatic IPC models BX-56A/BX-59A,
led/watchdog/battery on these models are same, actual drivers for
models will be sent in separate patches.
Signed-off-by: xingtong.wu <xingtong.wu@siemens.com >
Link: https://lore.kernel.org/r/20230731071424.4663-2-xingtong_wu@163.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-07-31 14:23:58 +02:00
Henning Schild
1598e3f6e9
platform/x86/siemens: Kconfig: adjust help text
...
There was a copy and paste mistake where the module name was not
correct.
Fixes: 917f543407 ("platform/x86: simatic-ipc: add CMOS battery monitoring")
Signed-off-by: Henning Schild <henning.schild@siemens.com >
Link: https://lore.kernel.org/r/20230725093113.9739-3-henning.schild@siemens.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-07-31 13:13:56 +02:00
xingtong.wu
d0563dd334
platform/x86/siemens: simatic-ipc-batt: fix bat reading in BX_21A
...
There was a case missing in a switch statement which lead to that model
not actually reading the GPIOs. That switch statement got simplified
now. Additionally on that model we need to initialize one pin
differently. As a drive-by finding also add a missing newline.
Fixes: 917f543407 ("platform/x86: simatic-ipc: add CMOS battery monitoring")
Reported-by: Henning Schild <henning.schild@siemens.com >
Signed-off-by: xingtong.wu <xingtong.wu@siemens.com >
Signed-off-by: Henning Schild <henning.schild@siemens.com >
Link: https://lore.kernel.org/r/20230728083651.19747-1-henning.schild@siemens.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-07-31 13:13:48 +02:00
Henning Schild
9bc289b812
platform/x86: Move all simatic ipc drivers to the subdirectory siemens
...
With more files around move everything to a subdirectory. Users will
only see the several options once they enable the main one.
Suggested-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Henning Schild <henning.schild@siemens.com >
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Link: https://lore.kernel.org/r/20230719153518.13073-4-henning.schild@siemens.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
2023-07-31 12:50:19 +02:00