From e6a5d573d24cd375e09d24f136523cb3cc85c9d3 Mon Sep 17 00:00:00 2001 From: Kai Kuang Date: Wed, 12 Aug 2026 14:06:44 +0800 Subject: [PATCH] net: dsa: drop explicit NULL comparisons Replace explicit NULL comparisons with the boolean form to follow the kernel coding style: dev->class != NULL -> dev->class user_dev == NULL -> !user_dev No functional changes intended. Signed-off-by: Kai Kuang Reviewed-by: Andrew Lunn Reviewed-by: Joe Damato Link: https://patch.msgid.link/20260812060644.210997-1-kuangkai@kylinos.cn Signed-off-by: Jakub Kicinski --- net/dsa/dsa.c | 2 +- net/dsa/user.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index da53a666d4b8..2771c34e8400 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c @@ -1383,7 +1383,7 @@ static int dsa_switch_parse_of(struct dsa_switch *ds, struct device_node *dn) static int dev_is_class(struct device *dev, const void *class) { - if (dev->class != NULL && !strcmp(dev->class->name, class)) + if (dev->class && !strcmp(dev->class->name, class)) return 1; return 0; diff --git a/net/dsa/user.c b/net/dsa/user.c index 4065c6ee6fc6..041f9060c8ef 100644 --- a/net/dsa/user.c +++ b/net/dsa/user.c @@ -2779,7 +2779,7 @@ int dsa_user_create(struct dsa_port *port) user_dev = alloc_netdev_mqs(sizeof(struct dsa_user_priv), name, assign_type, ether_setup, ds->num_tx_queues, 1); - if (user_dev == NULL) + if (!user_dev) return -ENOMEM; user_dev->rtnl_link_ops = &dsa_link_ops;