From e59fe5e0c418da4cf0432faa0fc9062d56bd98b1 Mon Sep 17 00:00:00 2001 From: Marc Kleine-Budde Date: Thu, 19 Mar 2026 17:55:42 +0100 Subject: [PATCH] spi: spi-fsl-lpspi: fsl_lpspi_can_dma(): directly assign return value to fsl_lpspi->usedma The function fsl_lpspi_can_dma() returns a bool. Simplify the code, remove the if/else and assign the return value of fsl_lpspi_can_dma() directly to fsl_lpspi->usedma. Signed-off-by: Marc Kleine-Budde Link: https://patch.msgid.link/20260319-spi-fsl-lpspi-cleanups-v2-8-02b56c5d44a8@pengutronix.de Signed-off-by: Mark Brown --- drivers/spi/spi-fsl-lpspi.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 904195f7b050..577403026c68 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -519,10 +519,7 @@ static int fsl_lpspi_prepare_message(struct spi_controller *controller, fsl_lpspi->usedma = false; ret = fsl_lpspi_setup_transfer(controller, spi, t); - if (fsl_lpspi_can_dma(controller, spi, t)) - fsl_lpspi->usedma = true; - else - fsl_lpspi->usedma = false; + fsl_lpspi->usedma = fsl_lpspi_can_dma(controller, spi, t); if (ret < 0) return ret; @@ -796,10 +793,7 @@ static int fsl_lpspi_transfer_one(struct spi_controller *controller, spi_controller_get_devdata(controller); int ret; - if (fsl_lpspi_can_dma(controller, spi, t)) - fsl_lpspi->usedma = true; - else - fsl_lpspi->usedma = false; + fsl_lpspi->usedma = fsl_lpspi_can_dma(controller, spi, t); ret = fsl_lpspi_setup_transfer(controller, spi, t); if (ret < 0)