From dfd1d2f7eb3956e3646ac33595e093b1b7fdaa1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= Date: Fri, 20 Feb 2026 19:09:03 +0200 Subject: [PATCH] drm/xe/fbdev: Fix BIOS FB vs. stolen size check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Looks like stolen->size is in bytes, not pages. Remove the bogus PAGE_SHIFT stuff. Also for some random reason xe rejects the FB if it takes up exactly half of stolen, whereas i915 allows it to be used in that case. Adjust xe to follow the i915 rule for consistency. v2: rebase related updates Signed-off-by: Ville Syrjälä Signed-off-by: Vinod Govindapillai Reviewed-by: Uma Shankar Acked-by: Mika Kahola Link: https://patch.msgid.link/20260220170908.201422-2-vinod.govindapillai@intel.com --- drivers/gpu/drm/xe/display/xe_initial_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/display/xe_initial_plane.c b/drivers/gpu/drm/xe/display/xe_initial_plane.c index 4cfeafcc158d..38ecc201ac4e 100644 --- a/drivers/gpu/drm/xe/display/xe_initial_plane.c +++ b/drivers/gpu/drm/xe/display/xe_initial_plane.c @@ -99,7 +99,7 @@ initial_plane_bo(struct xe_device *xe, * features. */ if (IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE) && - plane_config->size * 2 >> PAGE_SHIFT >= stolen->size) + plane_config->size * 2 > stolen->size) return NULL; }