From b4e28b4db72c8005baf4bacfeb8fcf686b13154e Mon Sep 17 00:00:00 2001 From: Jim Cromie Date: Thu, 18 Jun 2026 13:07:15 -0600 Subject: [PATCH] kernel/params: fix a pr_debug(" %p ") in parse_one() Inside parse_one(), the core parameter-parsing engine prints the address of the parameter-set callback function using %p: pr_debug("handling %s with %p\n", param, params[i].ops->set); Since the string value of the parameter being parsed (val) is already available, print the parameter name and its value instead, and avoid tainting the kernel by exposing a kernel-ptr. Link: https://lore.kernel.org/20260618190715.3563047-1-jim.cromie@gmail.com Signed-off-by: Jim Cromie Cc: Greg Kroah-Hartman Signed-off-by: Andrew Morton --- kernel/params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/params.c b/kernel/params.c index a668863a4bb6..5c8a05921e28 100644 --- a/kernel/params.c +++ b/kernel/params.c @@ -136,8 +136,8 @@ static int parse_one(char *param, if (!val && !(params[i].ops->flags & KERNEL_PARAM_OPS_FL_NOARG)) return -EINVAL; - pr_debug("handling %s with %p\n", param, - params[i].ops->set); + pr_debug("handling %s with value '%s'\n", param, + val ? val : "no-arg"); kernel_param_lock(params[i].mod); if (param_check_unsafe(¶ms[i])) err = params[i].ops->set(val, ¶ms[i]);