From b33f6e98b36b6d83f92ba788b986dac8ba7fc653 Mon Sep 17 00:00:00 2001 From: Ridong Chen Date: Fri, 24 Jul 2026 11:34:34 +0800 Subject: [PATCH] mm: vmscan: drop unused gfp_mask parameter from __node_reclaim() Commit 57972c78e678 ("mm/vmscan: make __node_reclaim() more generic") moved the scan_control construction out to the callers and passed the struct in by pointer. After that change every use of the gfp mask inside __node_reclaim() goes through sc->gfp_mask, leaving the gfp_mask parameter unused. Just remove the dead parameter and update the callers accordingly. No functional change. Link: https://lore.kernel.org/20260724033435.2573323-4-ridong.chen@linux.dev Signed-off-by: Ridong Chen Acked-by: Shakeel Butt Acked-by: Johannes Weiner Reviewed-by: Muchun Song Reviewed-by: Barry Song Reviewed-by: Qi Zheng Cc: Axel Rasmussen Cc: David Hildenbrand Cc: Davidlohr Bueso Cc: Kairui Song Cc: Lorenzo Stoakes Cc: Michal Hocko Cc: Roman Gushchin Cc: Wei Xu Cc: Yuanchu Xie Cc: Zhongkun He Cc: Baolin Wang Signed-off-by: Andrew Morton --- mm/vmscan.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b93bca48359a..b992f4e2e698 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -7740,7 +7740,7 @@ static unsigned long node_pagecache_reclaimable(struct pglist_data *pgdat) /* * Try to free up some pages from this node through reclaim. */ -static unsigned long __node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, +static unsigned long __node_reclaim(struct pglist_data *pgdat, unsigned long nr_pages, struct scan_control *sc) { @@ -7832,7 +7832,7 @@ unsigned long node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned i if (test_and_set_bit_lock(PGDAT_RECLAIM_LOCKED, &pgdat->flags)) return 0; - ret = __node_reclaim(pgdat, gfp_mask, nr_pages, &sc); + ret = __node_reclaim(pgdat, nr_pages, &sc); clear_bit_unlock(PGDAT_RECLAIM_LOCKED, &pgdat->flags); if (ret >= nr_pages) @@ -7845,7 +7845,7 @@ unsigned long node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned i #else -static unsigned long __node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, +static unsigned long __node_reclaim(struct pglist_data *pgdat, unsigned long nr_pages, struct scan_control *sc) { @@ -7958,8 +7958,7 @@ int user_proactive_reclaim(char *buf, &pgdat->flags)) return -EBUSY; - reclaimed = __node_reclaim(pgdat, gfp_mask, - batch_size, &sc); + reclaimed = __node_reclaim(pgdat, batch_size, &sc); clear_bit_unlock(PGDAT_RECLAIM_LOCKED, &pgdat->flags); }