From 505d48c93896948c9a430fa96a303af114566db9 Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Wed, 15 Jul 2026 21:50:28 +0800 Subject: [PATCH 1/3] counter: stm32-timer-cnt: Remove redundant dev_err() devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Reviewed-by: Joshua Crofts Link: https://lore.kernel.org/r/20260715135030.326290-2-panchuang@vivo.com Signed-off-by: William Breathitt Gray --- drivers/counter/stm32-timer-cnt.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c index 3d3384cbea87..954a22dabb99 100644 --- a/drivers/counter/stm32-timer-cnt.c +++ b/drivers/counter/stm32-timer-cnt.c @@ -760,11 +760,8 @@ static int stm32_timer_cnt_probe(struct platform_device *pdev) /* All events reported through the global interrupt */ ret = devm_request_irq(&pdev->dev, ddata->irq[0], stm32_timer_cnt_isr, 0, dev_name(dev), counter); - if (ret) { - dev_err(dev, "Failed to request irq %d (err %d)\n", - ddata->irq[0], ret); + if (ret) return ret; - } } else { for (i = 0; i < priv->nr_irqs; i++) { /* @@ -776,11 +773,8 @@ static int stm32_timer_cnt_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, ddata->irq[i], stm32_timer_cnt_isr, 0, dev_name(dev), counter); - if (ret) { - dev_err(dev, "Failed to request irq %d (err %d)\n", - ddata->irq[i], ret); + if (ret) return ret; - } } } From ccd73fc6fbd775b4981855717f85b769f0cf4f59 Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Wed, 15 Jul 2026 21:50:29 +0800 Subject: [PATCH 2/3] counter: ti-ecap-capture: Remove redundant dev_err_probe() devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() call. Signed-off-by: Pan Chuang Reviewed-by: Joshua Crofts Link: https://lore.kernel.org/r/20260715135030.326290-3-panchuang@vivo.com Signed-off-by: William Breathitt Gray --- drivers/counter/ti-ecap-capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/counter/ti-ecap-capture.c b/drivers/counter/ti-ecap-capture.c index 3586a7ab9887..5fe51e894145 100644 --- a/drivers/counter/ti-ecap-capture.c +++ b/drivers/counter/ti-ecap-capture.c @@ -514,7 +514,7 @@ static int ecap_cnt_probe(struct platform_device *pdev) ret = devm_request_irq(dev, ret, ecap_cnt_isr, 0, pdev->name, counter_dev); if (ret) - return dev_err_probe(dev, ret, "failed to request irq\n"); + return ret; platform_set_drvdata(pdev, counter_dev); From 353b2e09f44a91e64c6b8117df46b6999c52e465 Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Wed, 15 Jul 2026 21:50:30 +0800 Subject: [PATCH 3/3] counter: ti-eqep: Remove redundant dev_err_probe() devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() call. Signed-off-by: Pan Chuang Reviewed-by: Joshua Crofts Reviewed-by: David Lechner Link: https://lore.kernel.org/r/20260715135030.326290-4-panchuang@vivo.com Signed-off-by: William Breathitt Gray --- drivers/counter/ti-eqep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c index d21c157e531a..ec6633e5a289 100644 --- a/drivers/counter/ti-eqep.c +++ b/drivers/counter/ti-eqep.c @@ -527,7 +527,7 @@ static int ti_eqep_probe(struct platform_device *pdev) err = devm_request_threaded_irq(dev, irq, NULL, ti_eqep_irq_handler, IRQF_ONESHOT, dev_name(dev), counter); if (err < 0) - return dev_err_probe(dev, err, "failed to request IRQ\n"); + return err; counter->name = dev_name(dev); counter->parent = dev;