From 879c9151572317e8ddb6ab6c57a7689bf580efc9 Mon Sep 17 00:00:00 2001 From: Codrin Ciubotariu Date: Mon, 16 Sep 2024 16:19:09 +0300 Subject: [PATCH 1/2] ASoC: atmel: atmel_ssc_dai: Add stream names Add required stream names for DPCM and future use-cases. [andrei.simion@microchip.com: Adjust commit title. Reword commit message.] Reviewed-by: Alexandre Belloni Signed-off-by: Codrin Ciubotariu Signed-off-by: Andrei Simion Link: https://patch.msgid.link/20240916131910.22680-2-andrei.simion@microchip.com Signed-off-by: Mark Brown --- sound/soc/atmel/atmel_ssc_dai.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index 3763454436c1..7047f17fe7a8 100644 --- a/sound/soc/atmel/atmel_ssc_dai.c +++ b/sound/soc/atmel/atmel_ssc_dai.c @@ -836,6 +836,7 @@ static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { static struct snd_soc_dai_driver atmel_ssc_dai = { .playback = { + .stream_name = "Playback", .channels_min = 1, .channels_max = 2, .rates = SNDRV_PCM_RATE_CONTINUOUS, @@ -843,6 +844,7 @@ static struct snd_soc_dai_driver atmel_ssc_dai = { .rate_max = 384000, .formats = ATMEL_SSC_FORMATS,}, .capture = { + .stream_name = "Capture", .channels_min = 1, .channels_max = 2, .rates = SNDRV_PCM_RATE_CONTINUOUS, From ac8775d7de5a8ccac225a398cbce9fb9fffdbb9f Mon Sep 17 00:00:00 2001 From: Codrin Ciubotariu Date: Mon, 16 Sep 2024 16:19:10 +0300 Subject: [PATCH 2/2] ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation Drop S24_LE format because it is not supported if more than 2 channels (of TDM slots) are used. This limitation makes it impractical for use cases requiring more than 2 TDM slots, leading to potential issues in multi-channel configurations. [andrei.simion@microchip.com: Reword the commit title and the commit message. Add code comment to explain the removed code.] Signed-off-by: Codrin Ciubotariu Signed-off-by: Andrei Simion Reviewed-by: Alexandre Belloni Link: https://patch.msgid.link/20240916131910.22680-3-andrei.simion@microchip.com Signed-off-by: Mark Brown --- sound/soc/atmel/atmel_ssc_dai.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index 7047f17fe7a8..89098f41679c 100644 --- a/sound/soc/atmel/atmel_ssc_dai.c +++ b/sound/soc/atmel/atmel_ssc_dai.c @@ -821,8 +821,9 @@ static int atmel_ssc_resume(struct snd_soc_component *component) return 0; } +/* S24_LE is not supported if more than 2 channels (of TDM slots) are used. */ #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) + SNDRV_PCM_FMTBIT_S32_LE) static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { .startup = atmel_ssc_startup,