mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-07-16 13:19:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

perf cs-etm: Add fix for coresight trace for any range of CPUs

Browse Source 
The current implementation supports coresight trace decode for a range
of CPUs, if the first CPU is CPU0.

Perf report segfaults, if tried for sparse CPUs list and also for
any range of CPUs(non zero first CPU).

Adding a fix to perf report for any range of CPUs and for sparse list.

Signed-off-by: Ganapatrao Kulkarni <gankulkarni@os.amperecomputing.com>
Link: https://lore.kernel.org/r/20230421055253.83912-1-gankulkarni@os.amperecomputing.com
Cc: suzuki.poulose@arm.com
Cc: acme@kernel.org
Cc: mathieu.poirier@linaro.org
Cc: mike.leach@linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: darren@os.amperecomputing.com
Cc: scclevenger@os.amperecomputing.com
Cc: scott@os.amperecomputing.com
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Ganapatrao Kulkarni
2023-04-20 22:52:53 -07:00
committed by Arnaldo Carvalho de Melo
parent d199226143
commit 6bf86cada3
1 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tools/perf/util/cs-etm.c
View File

@@ -290,6 +290,25 @@ static int cs_etm__metadata_set_trace_id(u8 trace_chan_id, u64 *cpu_metadata)
(typeof(_mask))(((_reg) & (_mask)) >> __bf_shf(_mask)); \ (typeof(_mask))(((_reg) & (_mask)) >> __bf_shf(_mask)); \
}) })
/*
* Get a metadata for a specific cpu from an array.
*
*/
static u64 *get_cpu_data(struct cs_etm_auxtrace *etm, int cpu)
{
int i;
u64 *metadata = NULL;
for (i = 0; i < etm->num_cpu; i++) {
if (etm->metadata[i][CS_ETM_CPU] == (u64)cpu) {
metadata = etm->metadata[i];
break;
}
}
return metadata;
}
/* /*
* Handle the PERF_RECORD_AUX_OUTPUT_HW_ID event. * Handle the PERF_RECORD_AUX_OUTPUT_HW_ID event.
* *
@@ -359,8 +378,11 @@ static int cs_etm__process_aux_output_hw_id(struct perf_session *session,
return 0; return 0;
} }
cpu_data = get_cpu_data(etm, cpu);
if (cpu_data == NULL)
return err;
/* not one we've seen before - lets map it */ /* not one we've seen before - lets map it */
cpu_data = etm->metadata[cpu];
err = cs_etm__map_trace_id(trace_chan_id, cpu_data); err = cs_etm__map_trace_id(trace_chan_id, cpu_data);
if (err) if (err)
return err; return err;