From 5aef4cb3210d74f92dc6bb86a431a34be93528a6 Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Fri, 10 Jul 2026 19:02:46 +0800 Subject: [PATCH] ata: pata_mpc52xx: Remove redundant dev_err() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang Reviewed-by: Hannes Reinecke Signed-off-by: Damien Le Moal --- drivers/ata/pata_mpc52xx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c index 210a63283f62..1739743427cf 100644 --- a/drivers/ata/pata_mpc52xx.c +++ b/drivers/ata/pata_mpc52xx.c @@ -769,10 +769,8 @@ static int mpc52xx_ata_probe(struct platform_device *op) task_irq = bcom_get_task_irq(dmatsk); rv = devm_request_irq(&op->dev, task_irq, &mpc52xx_ata_task_irq, 0, "ATA task", priv); - if (rv) { - dev_err(&op->dev, "error requesting DMA IRQ\n"); + if (rv) goto err2; - } priv->dmatsk = dmatsk; /* Init the hw */