From 31ee1582717e220cc5a3fa8f3940d5693c5c9169 Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Sun, 26 Apr 2026 22:17:46 -0700 Subject: [PATCH] wifi: mt76: fix of_get_mac_address error handling Check return value instead of is_valid_ether_addr. The latter is handled by the former. Signed-off-by: Rosen Penev Acked-by: Lorenzo Bianconi Link: https://patch.msgid.link/20260427051746.954704-1-rosenp@gmail.com Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c index afdb73661866..b99d7452800f 100644 --- a/drivers/net/wireless/mediatek/mt76/eeprom.c +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c @@ -181,7 +181,7 @@ mt76_eeprom_override(struct mt76_phy *phy) if (err == -EPROBE_DEFER) return err; - if (!is_valid_ether_addr(phy->macaddr)) { + if (err) { eth_random_addr(phy->macaddr); dev_info(dev->dev, "Invalid MAC address, using random address %pM\n",