From 1f2b1870743460274d3fac91bcd7179e51f232db Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Wed, 22 Jul 2026 15:57:44 +0800 Subject: [PATCH] fbdev: pxa3xx-gcu: Remove redundant dev_err() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang Signed-off-by: Helge Deller --- drivers/video/fbdev/pxa3xx-gcu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c index a2320e2fb8f2..fc5bd7e7aae6 100644 --- a/drivers/video/fbdev/pxa3xx-gcu.c +++ b/drivers/video/fbdev/pxa3xx-gcu.c @@ -615,10 +615,8 @@ static int pxa3xx_gcu_probe(struct platform_device *pdev) ret = devm_request_irq(dev, irq, pxa3xx_gcu_handle_irq, 0, DRV_NAME, priv); - if (ret < 0) { - dev_err(dev, "request_irq failed\n"); + if (ret < 0) return ret; - } /* allocate dma memory */ priv->shared = dma_alloc_coherent(dev, SHARED_SIZE,