mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-05-16 11:21:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

ACPI: PAD: xen: Convert to a platform driver

Browse Source 
In all cases in which a struct acpi_driver is used for binding a driver
to an ACPI device object, a corresponding platform device is created by
the ACPI core and that device is regarded as a proper representation of
underlying hardware.  Accordingly, a struct platform_driver should be
used by driver code to bind to that device.  There are multiple reasons
why drivers should not bind directly to ACPI device objects [1].

Overall, it is better to bind drivers to platform devices than to their
ACPI companions, so convert the Xen ACPI processor aggregator device
(PAD) driver to a platform one.

While this is not expected to alter functionality, it changes sysfs
layout and so it will be visible to user space.

Link: https://lore.kernel.org/all/2396510.ElGaqSPkdT@rafael.j.wysocki/ [1]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/8683270.T7Z3S40VBb@rafael.j.wysocki
This commit is contained in:
Rafael J. Wysocki
2026-03-14 12:57:23 +01:00
parent a56a658f24
commit 112b2f978a
1 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/xen/xen-acpi-pad.c
View File

@@ -11,6 +11,7 @@
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/types.h> #include <linux/types.h>
#include <linux/acpi.h> #include <linux/acpi.h>
#include <linux/platform_device.h>
#include <xen/xen.h> #include <xen/xen.h>
#include <xen/interface/version.h> #include <xen/interface/version.h>
#include <xen/xen-ops.h> #include <xen/xen-ops.h>
@@ -107,8 +108,9 @@ static void acpi_pad_notify(acpi_handle handle, u32 event,
} }
} }
static int acpi_pad_add(struct acpi_device *device) static int acpi_pad_probe(struct platform_device *pdev)
{ {
struct acpi_device *device = ACPI_COMPANION(&pdev->dev);
acpi_status status; acpi_status status;
strcpy(acpi_device_name(device), ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME); strcpy(acpi_device_name(device), ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME);
@@ -122,13 +124,13 @@ static int acpi_pad_add(struct acpi_device *device)
return 0; return 0;
} }
static void acpi_pad_remove(struct acpi_device *device) static void acpi_pad_remove(struct platform_device *pdev)
{ {
mutex_lock(&xen_cpu_lock); mutex_lock(&xen_cpu_lock);
xen_acpi_pad_idle_cpus(0); xen_acpi_pad_idle_cpus(0);
mutex_unlock(&xen_cpu_lock); mutex_unlock(&xen_cpu_lock);
acpi_remove_notify_handler(device->handle, acpi_remove_notify_handler(ACPI_HANDLE(&pdev->dev),
ACPI_DEVICE_NOTIFY, acpi_pad_notify); ACPI_DEVICE_NOTIFY, acpi_pad_notify);
} }
@@ -137,13 +139,12 @@ static const struct acpi_device_id pad_device_ids[] = {
{"", 0}, {"", 0},
}; };
static struct acpi_driver acpi_pad_driver = { static struct platform_driver acpi_pad_driver = {
.name = "processor_aggregator", .probe = acpi_pad_probe,
.class = ACPI_PROCESSOR_AGGREGATOR_CLASS, .remove = acpi_pad_remove,
.ids = pad_device_ids, .driver = {
.ops = { .name = "acpi_processor_aggregator",
.add = acpi_pad_add, .acpi_match_table = pad_device_ids,
.remove = acpi_pad_remove,
}, },
}; };
@@ -157,6 +158,6 @@ static int __init xen_acpi_pad_init(void)
if (!xen_running_on_version_or_later(4, 2)) if (!xen_running_on_version_or_later(4, 2))
return -ENODEV; return -ENODEV;
return acpi_bus_register_driver(&acpi_pad_driver); return platform_driver_register(&acpi_pad_driver);
} }
subsys_initcall(xen_acpi_pad_init); subsys_initcall(xen_acpi_pad_init);