mirror of
https://github.com/compiler-explorer/compiler-explorer.git
synced 2026-07-22 02:56:57 -04:00
5aea167ce5
The previous find-node script only compared the major version (22) from .node-version, but package.json requires >=22.12.0. This meant find-node could accept and cache a v22.0.0 node that would later fail npm due to the engines constraint. Fix by: - Updating .node-version from '22' to '22.12.0' (the actual minimum) - Rewriting find-node to read full semver from .node-version and compare using a proper semver_ge() function (awk-based, POSIX-portable) - Using only the major component for nvm/fnm version manager queries (e.g. 'nvm which 22') while still validating the full semver after discovery - Updating Makefile to depend on .node-version so bumping the pinned version re-resolves the node binary cache Addresses review comment: https://github.com/compiler-explorer/compiler-explorer/pull/8845#discussion_r3515010694