Files
mattgodbolt-molty 40e05210b0 Address Copilot's second review pass
(Q1, lib/properties-validator.ts) `extractTargetTokens` now strips
surrounding single/double quotes from each token before pattern-matching
flags. Two real configs use quoted options (`python.amazon.properties`
micropython group). Caught by Copilot.

(Q2, lib/base-compiler.ts) Stale comment fixed. The previous commit
removed the warning in `compiler-finder.ts` but left the cross-reference
saying "compiler-finder logs a warning". Comment now reflects reality.

(Q3, lib/compiler-finder.ts) Already consistent after the previous
commit, but worth noting: the comment says "we don't log" because in
~all CE installs the amd64 fallback is correct, and CI catches the
production case via `findCompilersWithoutInstructionSet`.

Bonus: the new quote-stripping immediately surfaced a false-positive
in the consistency check — micropython has `options="-march=x64"` but
its `instructionSet=mpy` (bytecode), so `-march` doesn't determine
output. Added `isHostArchInstructionSet(iset)` predicate in
`lib/instructionsets.ts` (returns true only for InstructionSets in
TARGET_SUBSTRINGS, i.e. real CPU archs); the consistency check now
skips bytecode/IR/VM-typed compilers, where runtime `-target`/`-march`
flags don't affect output arch.

Tests added: quote-stripping in `extractTargetTokens`, and
`isHostArchInstructionSet` per-arch behaviour.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-10 12:49:20 -05:00
..
2025-07-28 10:34:46 -05:00
2025-07-28 10:34:46 -05:00