Files
compiler-explorer/lib/handlers/noscript.ts
Matt Godbolt f94ff8332a Refactor: Split app.ts into smaller modules (#7681)
## Summary
This PR significantly improves maintainability by breaking up the 880+ line monolithic app.ts file into smaller, focused modules with proper testing. The code is now organized into dedicated modules under the lib/app/ directory, making the codebase more maintainable and testable.

## Key changes
- Extract functionality into modules under lib/app/ directory:
  - Command-line handling (cli.ts)
  - Configuration loading (config.ts)
  - Web server setup and middleware (server.ts)
  - Core application initialization (main.ts)
  - URL handlers, routing, rendering, and controllers
- Add comprehensive unit tests for all new modules
- Make compilationQueue non-optional in the compilation environment
- Improve separation of concerns with dedicated interfaces
- Ensure backward compatibility with existing functionality
- Maintain cross-platform compatibility (Windows/Linux)

## Benefits
- Improved code organization and modularity
- Enhanced testability with proper unit tests
- Better separation of concerns
- Reduced complexity in individual files
- Easier maintenance and future development

This refactoring is a significant step toward a more maintainable codebase while preserving all existing functionality.
2025-05-20 17:53:24 -05:00

158 lines
6.0 KiB
TypeScript

// Copyright (c) 2020, Compiler Explorer Authors
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are met:
//
// * Redistributions of source code must retain the above copyright notice,
// this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above copyright
// notice, this list of conditions and the following disclaimer in the
// documentation and/or other materials provided with the distribution.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
// ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
// POSSIBILITY OF SUCH DAMAGE.
import express from 'express';
import {isString} from '../../shared/common-utils.js';
import {LanguageKey} from '../../types/languages.interfaces.js';
import {assert} from '../assert.js';
import {ClientStateNormalizer} from '../clientstate-normalizer.js';
import {ClientState} from '../clientstate.js';
import {logger} from '../logger.js';
import {ClientOptionsHandler} from '../options-handler.js';
import {StorageBase} from '../storage/index.js';
import {isMobileViewer} from '../app/url-handlers.js';
import {RenderConfig} from './handler.interfaces.js';
import {cached, csp} from './middleware.js';
export class NoScriptHandler {
constructor(
private readonly router: express.Router,
private readonly clientOptionsHandler: ClientOptionsHandler,
private readonly renderConfig: RenderConfig,
private readonly storageHandler: StorageBase,
private readonly defaultLanguage: string | undefined,
) {}
initializeRoutes() {
this.router
.get('/noscript', cached, csp, (req, res) => {
this.renderNoScriptLayout(undefined, req, res);
})
.get('/noscript/z/:id', cached, csp, this.storedStateHandlerNoScript.bind(this))
.get('/noscript/sponsors', cached, csp, (req, res) => {
res.render(
'noscript/sponsors',
this.renderConfig(
{
embedded: false,
mobileViewer: isMobileViewer(req),
},
req.query,
),
);
})
.get('/noscript/:language', cached, csp, (req, res) => {
this.renderNoScriptLayout(undefined, req, res);
});
}
storedStateHandlerNoScript(req: express.Request, res: express.Response, next: express.NextFunction) {
const id = req.params.id;
this.storageHandler
.expandId(id)
.then(result => {
const config = JSON.parse(result.config);
let clientstate: ClientState;
if (config.content) {
const normalizer = new ClientStateNormalizer();
normalizer.fromGoldenLayout(config);
clientstate = normalizer.normalized;
} else {
clientstate = new ClientState(config);
}
this.renderNoScriptLayout(clientstate, req, res);
this.storageHandler.incrementViewCount(id).catch(err => {
logger.error(`Error incrementing view counts for ${id} - ${err}`);
});
})
.catch(err => {
logger.warn(`Could not expand ${id}: ${err}`);
next({
statusCode: 404,
message: `ID "${id}" could not be found`,
});
});
}
createDefaultState(wantedLanguage: LanguageKey) {
const options = this.clientOptionsHandler.get();
const state = new ClientState();
const session = state.findOrCreateSession(1);
session.language = wantedLanguage;
if (options.languages[wantedLanguage]) {
session.source = options.languages[wantedLanguage].example;
} else {
session.source = '';
}
const compiler = session.findOrCreateCompiler(1);
if (options.defaultCompiler[wantedLanguage]) {
compiler.id = options.defaultCompiler[wantedLanguage];
} else {
compiler.id = '';
}
return state;
}
renderNoScriptLayout(state: ClientState | undefined, req: express.Request, res: express.Response) {
let wantedLanguage = 'c++';
if (req.params?.language) {
wantedLanguage = req.params.language;
} else {
if (this.defaultLanguage) wantedLanguage = this.defaultLanguage;
if (req.query.language) {
const lang = req.query.language;
assert(isString(lang));
wantedLanguage = lang;
}
}
if (!state) {
state = this.createDefaultState(wantedLanguage as LanguageKey);
}
res.render(
'noscript/index',
this.renderConfig(
{
embedded: false,
mobileViewer: isMobileViewer(req),
wantedLanguage: wantedLanguage,
clientstate: state,
storedStateId: req.params.id || false,
},
req.query,
),
);
}
}