mirror of
https://github.com/compiler-explorer/compiler-explorer.git
synced 2025-12-27 09:23:52 -05:00
## Summary This PR makes URL serialization logic available to Node.js contexts (like Cypress tests) and replaces a hard-coded 4812-character base64 URL in tests with programmatically generated state. This builds on the shared utilities refactoring from #8246. ### Changes #### 1. Extract URL Serialization to Shared Module **Problem:** URL serialization code depended on GoldenLayout's browser-only ConfigMinifier, preventing Cypress spec files from importing it (they load in Node.js before running in browser). **Solution:** Created `shared/url-serialization.ts` with a Node-compatible ConfigMinifier reimplementation. **Technical Details:** - Reimplemented GoldenLayout's ConfigMinifier without browser dependencies - Moved serialization functions (`serialiseState`, `deserialiseState`, `risonify`, `unrisonify`) to shared module - Moved minification functions (`minifyConfig`, `unminifyConfig`) to shared module - Updated `static/url.ts` to use shared module instead of GoldenLayout - Added comprehensive test coverage in `test/url-serialization.ts` **Files:** - **New:** `shared/url-serialization.ts` (~279 lines) - **Modified:** `static/url.ts` (removed ~30 lines, eliminated GoldenLayout dependency) - **New:** `test/url-serialization.ts` (~96 lines) #### 2. Replace Hard-coded Cypress URL with Programmatic State **Before:** A hard-coded 4812-character base64 URL containing state for all panes ```typescript cy.visit('http://localhost:10240/#z:OYLghAFBqd5TB8IAsQGMD2ATApgUWwEsAXTAJwBoiQIAzIgG...'); ``` **After:** Programmatically generated state using `buildKnownGoodState()` function ```typescript const state = buildKnownGoodState(); const hash = serialiseState(state); cy.visit(`http://localhost:10240/#${hash}`, {...}); ``` **Benefits:** - Human-readable, maintainable test state - Programmatic generation from `PANE_DATA_MAP` keys - Layout optimized with 8 panes per row - Produces identical compressed URL format - Much easier to add/modify panes in the future #### 3. PANE_DATA_MAP Consistency Improvements Updated `PANE_DATA_MAP` to use component names exactly as registered with GoldenLayout: **Key renames:** - `preprocessor` → `pp` - `llvmir` → `ir` - `pipeline` → `llvmOptPipelineView` - `mir` → `rustmir` - `hir` → `rusthir` - `macro` → `rustmacroexp` - `core` → `haskellCore` - `stg` → `haskellStg` - `cmm` → `haskellCmm` - `dump` → `gccdump` - `tree` → `gnatdebugtree` - `debug` → `gnatdebug` **Added panes:** `codeEditor`, `compiler`, `conformance`, `output` (were missing from map) **Re-enabled tests:** - `yul` pane test (was commented out, now fixed) - `clojuremacroexp` pane test (was commented out, now fixed) - `cfg` pane test (had TODO, now removed) **Why this matters:** The `buildKnownGoodState()` function uses `Object.keys(PANE_DATA_MAP)` as the `componentName` property, so keys must match the actual registered component names for GoldenLayout to find them. ## Test Plan - [x] All Cypress tests pass (confirmed by @mattgodbolt) - [x] TypeScript compilation passes (`npm run ts-check`) - [x] Linting passes (`npm run lint`) - [x] URL serialization tests pass (3/3 tests) - [x] Pre-commit hooks pass - [x] Related vitest tests pass ## Dependencies - Builds on #8246 (shared utilities refactoring - already merged) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude <noreply@anthropic.com>
91 lines
3.4 KiB
TypeScript
91 lines
3.4 KiB
TypeScript
// Copyright (c) 2022, Compiler Explorer Authors
|
|
// All rights reserved.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright notice,
|
|
// this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above copyright
|
|
// notice, this list of conditions and the following disclaimer in the
|
|
// documentation and/or other materials provided with the distribution.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
// ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
|
|
// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
// POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
import {isString} from './common-utils.js';
|
|
import {parse} from './stacktrace.js';
|
|
|
|
// This file defines three assert utilities:
|
|
// assert(condition, message?, extra_info...?): asserts condition
|
|
// unwrap(x: T | undefined | null, message?, extra_info...?): T
|
|
// assert_type(x, class, message?, extra_info...?)
|
|
|
|
function get_diagnostic() {
|
|
const e = new Error();
|
|
const trace = parse(e);
|
|
if (trace.length >= 4) {
|
|
const invoker_frame = trace[3];
|
|
if (invoker_frame.fileName && invoker_frame.lineNumber) {
|
|
return {
|
|
file: invoker_frame.fileName,
|
|
line: invoker_frame.lineNumber,
|
|
};
|
|
}
|
|
}
|
|
}
|
|
|
|
function fail(fail_message: string, user_message: string | undefined, args: any[]): never {
|
|
// Assertions will look like:
|
|
// Assertion failed
|
|
// Assertion failed: Foobar
|
|
// Assertion failed: Foobar, [{"foo": "bar"}]
|
|
let assert_line = fail_message;
|
|
if (user_message) {
|
|
assert_line += `: ${user_message}`;
|
|
}
|
|
if (args.length > 0) {
|
|
try {
|
|
assert_line += ', ' + JSON.stringify(args);
|
|
} catch {}
|
|
}
|
|
|
|
const diagnostic = get_diagnostic();
|
|
if (diagnostic) {
|
|
throw new Error(assert_line + `, at ${diagnostic.file}:${diagnostic.line}`);
|
|
}
|
|
throw new Error(assert_line);
|
|
}
|
|
|
|
export function assert(c: unknown, message?: string, ...extra_info: any[]): asserts c {
|
|
if (!c) {
|
|
fail('Assertion failed', message, extra_info);
|
|
}
|
|
}
|
|
|
|
export function unwrap<T>(x: T | undefined | null, message?: string, ...extra_info: any[]): T {
|
|
if (x === undefined || x === null) {
|
|
fail('Unwrap failed', message, extra_info);
|
|
}
|
|
return x;
|
|
}
|
|
|
|
// This mainly a utility for JQuery.val(): string | number | string[] | undefined, in our code we typically want a
|
|
// single string.
|
|
// T is syntax sugar for unwrapping to a string union
|
|
export function unwrapString<T extends string>(x: any, message?: string, ...extra_info: any[]): T {
|
|
if (!isString(x)) {
|
|
fail('String unwrap failed', message, extra_info);
|
|
}
|
|
return x as T;
|
|
}
|