Files
compiler-explorer/static/panes/opt-view.ts
Matt Godbolt 03d20c5fde Move assert.ts and rison.ts to shared/ directory (#8246)
## Summary
Moves `static/assert.ts` and `static/rison.ts` to `shared/` directory to
make them available to both frontend and backend code without browser
dependencies. Updates all import paths across the codebase (~47 files).

## Motivation
This refactoring eliminates browser dependencies in these utilities,
allowing them to be imported by Node.js contexts (like Cypress test
files) without causing module load failures. This is a prerequisite for
upcoming Cypress test improvements.

## Changes
- Move `static/assert.ts` → `shared/assert.ts`
- Move `static/rison.ts` → `shared/rison.ts`  
- Update `biome.json` to allow `hasOwnProperty` in `shared/` directory
- Update all imports across `static/`, `lib/`, and `test/` directories
(47 files changed)

## Benefits
- No functional changes, purely a code reorganization
- Makes these utilities accessible to both frontend and backend without
circular dependencies
- Enables future Cypress improvements that require these utilities in
Node.js context
- All tests pass ✓ (699 tests)

## Test Plan
- [x] TypeScript compilation passes
- [x] Linting passes
- [x] All unit tests pass (699 tests)
- [x] Pre-commit hooks pass

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude <noreply@anthropic.com>
2025-11-04 10:58:11 -06:00

230 lines
9.0 KiB
TypeScript

// Copyright (c) 2017, Jared Wyles
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are met:
//
// * Redistributions of source code must retain the above copyright notice,
// this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above copyright
// notice, this list of conditions and the following disclaimer in the
// documentation and/or other materials provided with the distribution.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
// ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
// POSSIBILITY OF SUCH DAMAGE.
import {Container} from 'golden-layout';
import $ from 'jquery';
import * as monaco from 'monaco-editor';
import _ from 'underscore';
import {unwrap} from '../../shared/assert.js';
import {CompilationResult} from '../../types/compilation/compilation.interfaces.js';
import {CompilerInfo} from '../../types/compiler.interfaces.js';
import {Hub} from '../hub.js';
import {extendConfig} from '../monaco-config.js';
import {Toggles} from '../widgets/toggles.js';
import {OptRemark, OptState} from './opt-view.interfaces.js';
import {MonacoPaneState} from './pane.interfaces.js';
import {MonacoPane} from './pane.js';
export class Opt extends MonacoPane<monaco.editor.IStandaloneCodeEditor, OptState> {
// Note: bool | undef here instead of just bool because of an issue with field initialization order
private isCompilerSupported?: boolean;
private filters: Toggles;
private toggleWrapButton: Toggles;
private wrapButton: JQuery<HTMLElement>;
private wrapTitle: JQuery<HTMLElement>;
// Keep optRemarks as state, to avoid triggering a recompile when options change
private optRemarks: OptRemark[];
private optRemarkViewZoneIds: string[];
constructor(hub: Hub, container: Container, state: OptState & MonacoPaneState) {
super(hub, container, state);
this.optRemarks = state.optOutput ?? [];
this.optRemarkViewZoneIds = [];
this.eventHub.emit('optViewOpened', this.compilerInfo.compilerId);
}
override getInitialHTML(): string {
return $('#opt-view').html();
}
override createEditor(editorRoot: HTMLElement): void {
this.editor = monaco.editor.create(
editorRoot,
extendConfig({
language: 'plaintext',
readOnly: true,
glyphMargin: true,
}),
);
}
override getPrintName() {
return 'Opt Remarks';
}
override registerButtons(state: OptState) {
super.registerButtons(state);
this.filters = new Toggles(this.domRoot.find('.filters'), state as unknown as Record<string, boolean>);
this.filters.on('change', () => this.showOptRemarks());
this.toggleWrapButton = new Toggles(this.domRoot.find('.options'), state as unknown as Record<string, boolean>);
this.toggleWrapButton.on('change', this.onToggleWrapChange.bind(this));
this.wrapButton = this.domRoot.find('.wrap-lines');
this.wrapTitle = this.wrapButton.prop('title');
if (state.wrap === true) {
this.wrapButton.prop('title', '[ON] ' + this.wrapTitle);
} else {
this.wrapButton.prop('title', '[OFF] ' + this.wrapTitle);
}
}
onToggleWrapChange(): void {
const state = this.getCurrentState();
if (state.wrap) {
this.editor.updateOptions({wordWrap: 'on'});
this.wrapButton.prop('title', '[ON] ' + this.wrapTitle);
} else {
this.editor.updateOptions({wordWrap: 'off'});
this.wrapButton.prop('title', '[OFF] ' + this.wrapTitle);
}
this.updateState();
}
override registerCallbacks() {
this.eventHub.emit('requestSettings');
this.eventHub.emit('findCompilers');
this.container.on('shown', this.resize, this);
const cursorSelectionThrottledFunction = _.throttle(this.onDidChangeCursorSelection.bind(this), 500);
this.editor.onDidChangeCursorSelection(e => {
cursorSelectionThrottledFunction(e);
});
this.editor.onDidLayoutChange(({contentWidth}) => {
this.showOptRemarks(contentWidth);
});
}
override onCompileResult(id: number, compiler: CompilerInfo, result: CompilationResult) {
if (this.compilerInfo.compilerId !== id || !this.isCompilerSupported) return;
this.editor.setValue(unwrap(result.source));
this.optRemarks = result.optOutput ?? [];
this.showOptRemarks();
// TODO: This is inelegant again. Previously took advantage of fourth argument for the compileResult event.
const lang = compiler.lang === 'c++' ? 'cpp' : compiler.lang;
const model = this.editor.getModel();
if (model != null && this.getCurrentEditorLanguage() !== lang) {
monaco.editor.setModelLanguage(model, lang);
}
if (!this.isAwaitingInitialResults) {
if (this.selection) {
this.editor.setSelection(this.selection);
this.editor.revealLinesInCenter(this.selection.startLineNumber, this.selection.endLineNumber);
}
this.isAwaitingInitialResults = true;
}
}
// Monaco language id of the current editor
getCurrentEditorLanguage() {
return this.editor.getModel()?.getLanguageId();
}
override getDefaultPaneName() {
return 'Opt Viewer';
}
showOptRemarks(width?: number) {
const filters = this.filters.get();
const includeMissed: boolean = filters['filter-missed'];
const includePassed: boolean = filters['filter-passed'];
const includeAnalysis: boolean = filters['filter-analysis'];
const remarksToDisplay = this.optRemarks.filter(rem => {
return (
!!rem.DebugLoc &&
((rem.optType === 'Missed' && includeMissed) ||
(rem.optType === 'Passed' && includePassed) ||
(rem.optType === 'Analysis' && includeAnalysis))
);
});
this.editor?.changeViewZones(accessor => {
const maxWidth = width ?? this.editor.getLayoutInfo().contentWidth;
this.optRemarkViewZoneIds.forEach(id => {
accessor.removeZone(id);
});
this.optRemarkViewZoneIds = remarksToDisplay.map(({displayString, optType, DebugLoc}) => {
const domNode = document.createElement('div');
domNode.classList.add('view-line', 'opt-line', optType.toLowerCase());
this.editor.applyFontInfo(domNode);
domNode.innerText = displayString;
// let the browser calculate the height that the text needs
domNode.style.visibility = 'hidden';
domNode.style.maxWidth = `${maxWidth}px`;
document.body.appendChild(domNode);
const heightInPx = domNode.clientHeight;
document.body.removeChild(domNode);
domNode.style.removeProperty('visibility');
domNode.style.removeProperty('max-width');
return accessor.addZone({
domNode,
heightInPx,
afterLineNumber: DebugLoc.Line === 0 ? 0 : DebugLoc.Line - 1,
});
});
});
}
override onCompiler(id: number, compiler: CompilerInfo | null, options: string, editorId: number, treeId: number) {
if (id === this.compilerInfo.compilerId) {
this.compilerInfo.compilerName = compiler ? compiler.name : '';
this.updateTitle();
this.isCompilerSupported = compiler ? compiler.supportsOptOutput : false;
if (!this.isCompilerSupported) {
this.editor.setValue('<OPT remarks are not supported for this compiler>');
this.optRemarks = [];
this.showOptRemarks();
}
}
}
override getCurrentState() {
return {
...this.filters.get(),
wrap: this.toggleWrapButton.get().wrap,
...super.getCurrentState(),
};
}
// Don't do anything for this pane
override sendPrintData() {}
override close() {
this.eventHub.unsubscribe();
this.eventHub.emit('optViewClosed', this.compilerInfo.compilerId);
this.editor.dispose();
}
}