mirror of
https://github.com/compiler-explorer/compiler-explorer.git
synced 2026-05-16 12:33:04 -04:00
53c7dd328b
Enable Biome's `organizeImports` with groups matching the original ESLint `import/order` configuration: 1. **Node builtins** (`node:fs`, `path`, etc.) 2. *(blank line)* 3. **Third-party packages** (`express`, `@sentry/node`, etc.) 4. *(blank line)* 5. **Local/relative imports** (`../foo.js`, `./bar.js`, aliases) This resolves the inconsistency where Biome wasn't enforcing import grouping, meaning new files would lose the blank-line separation that the old ESLint config enforced. ### Impact - **354 files** updated out of 738 checked (~48%) - **+188 / -240 lines** (net -52) — almost entirely single blank line additions/removals between import groups - No import reordering; purely group separator consistency Fixes #7373 🤖 Generated by LLM (Claude, via OpenClaw)
84 lines
3.6 KiB
TypeScript
84 lines
3.6 KiB
TypeScript
// Copyright (c) 2025, Compiler Explorer Authors
|
|
// All rights reserved.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright notice,
|
|
// this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above copyright
|
|
// notice, this list of conditions and the following disclaimer in the
|
|
// documentation and/or other materials provided with the distribution.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
// ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
|
|
// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
// POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
import {execSync} from 'node:child_process';
|
|
import * as fs from 'node:fs';
|
|
import * as net from 'node:net';
|
|
import * as os from 'node:os';
|
|
import * as path from 'node:path';
|
|
|
|
import {describe, it} from 'vitest';
|
|
|
|
describe('HeaptrackWrapper FD behavior tests', () => {
|
|
it('should verify net.Socket properly handles external FDs', async () => {
|
|
// This test verifies that net.Socket can handle external FDs and properly goes through its close sequence.
|
|
// This is critical for HeaptrackWrapper which creates sockets from pipe FDs.
|
|
|
|
if (process.platform === 'win32') {
|
|
return;
|
|
}
|
|
|
|
const tmpDir = os.tmpdir();
|
|
const pipePath = path.join(tmpDir, `test_pipe_${process.pid}_${Date.now()}`);
|
|
|
|
try {
|
|
// Create a named pipe (exactly like HeaptrackWrapper does)
|
|
execSync(`mkfifo "${pipePath}"`);
|
|
|
|
// Open the pipe with O_NONBLOCK (like HeaptrackWrapper does)
|
|
const O_NONBLOCK = fs.constants.O_NONBLOCK; // Use fs.constants for portability
|
|
const O_RDWR = fs.constants.O_RDWR;
|
|
const fd = fs.openSync(pipePath, O_RDWR | O_NONBLOCK);
|
|
|
|
// Create a net.Socket with the pipe FD (like HeaptrackWrapper)
|
|
const socket = new net.Socket({fd: fd, readable: true, writable: true});
|
|
|
|
// Set up close event listener
|
|
const closePromise = new Promise<void>(resolve => {
|
|
socket.on('close', () => {
|
|
// Close event fired - this means the socket went through its complete cleanup sequence
|
|
resolve();
|
|
});
|
|
});
|
|
|
|
// Destroy the socket (like HeaptrackWrapper does)
|
|
socket.destroy();
|
|
|
|
// Wait for close event to fire
|
|
await closePromise;
|
|
|
|
// Success! The socket properly handled the external FD and completed its close sequence. We assume
|
|
// (based on manual testing) that this includes closing the FD. We NEVER attempt to verify the FD
|
|
// state ourselves to avoid FD recycling race conditions.
|
|
} finally {
|
|
// Clean up the pipe
|
|
try {
|
|
fs.unlinkSync(pipePath);
|
|
} catch {
|
|
// Ignore cleanup errors
|
|
}
|
|
}
|
|
});
|
|
});
|