mirror of
https://github.com/compiler-explorer/compiler-explorer.git
synced 2026-07-22 01:46:48 -04:00
Fixes #8816.
- `setupTempDir()` exports the configured dir as `TMPDIR`, `TMP` *and*
`TEMP`. POSIX `os.tmpdir()` consults `TMPDIR` first, so the old TMP-only
export meant an inherited `TMPDIR` silently defeated `--tmp-dir`
(verified empirically; prod was protected only by `sudo env_reset` in
start.sh). Setting all three also covers native Windows (`TEMP` > `TMP`
there) and WSL, and means spawned tools reading any of the variables
agree.
- Restores the `os.tmpdir() !== tmpDir → throw` sanity check from
613d7f688 (#6052), lost in the #7681 split refactor.
- The startup log now prints `os.tmpdir()` — the value that actually
matters — instead of `TEMP || TMP`, which printed `undefined` on a
default Linux run.
- The `lib/temp.ts` exit hook was `process.on('exit', async ...)`: exit
handlers can't await, so it never removed anything. Replaced with a
synchronous `cleanupSync()` (tested).
- Test hygiene fix that the work surfaced: the temp-dir tests restored
the environment by reassigning `process.env` wholesale; a replaced
`process.env` is a plain object whose writes never reach the real
environment, while `os.tmpdir()` reads the real environ via `safeGetenv`
— so the suite silently leaked env state across tests (and into any test
running later in the same worker). Now saves/restores the individual
variables.
The WSL `%TEMP%`-discovery-failure path (`wsl-vc.ts` parsing garbage on
fallback, #8816 item 4) is deliberately untouched — Windows-specific and
unverifiable here.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: mattgodbolt-molty <mattgodbolt-molty@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
147 lines
4.9 KiB
TypeScript
147 lines
4.9 KiB
TypeScript
// Copyright (c) 2025, Compiler Explorer Authors
|
|
// All rights reserved.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright notice,
|
|
// this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above copyright
|
|
// notice, this list of conditions and the following disclaimer in the
|
|
// documentation and/or other materials provided with the distribution.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
// ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
|
|
// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
// POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
import fs from 'node:fs';
|
|
import os from 'node:os';
|
|
import path from 'node:path';
|
|
|
|
import {logger} from './logger.js';
|
|
import * as utils from './utils.js';
|
|
|
|
const pendingRemoval: string[] = [];
|
|
export type Stats = {
|
|
numCreated: number;
|
|
numActive: number;
|
|
numRemoved: number;
|
|
numAlreadyGone: number;
|
|
};
|
|
|
|
const stats = {
|
|
numCreated: 0,
|
|
numRemoved: 0,
|
|
numAlreadyGone: 0,
|
|
};
|
|
|
|
/**
|
|
* Get the current stats for temporary directories.
|
|
*/
|
|
export function getStats(): Stats {
|
|
return {
|
|
...stats,
|
|
numActive: pendingRemoval.length,
|
|
};
|
|
}
|
|
|
|
// Reset stats, for tests only.
|
|
export function resetStats() {
|
|
stats.numCreated = 0;
|
|
stats.numRemoved = 0;
|
|
stats.numAlreadyGone = 0;
|
|
}
|
|
|
|
/**
|
|
* The directory under which this module creates temporary directories (unless callers pass
|
|
* an absolute prefix). The --tmp-dir command line option is not read directly: at startup
|
|
* setupTempDir() exports it as $TMPDIR/$TMP/$TEMP, which os.tmpdir() consults.
|
|
* See lib/app/temp-dir.ts.
|
|
*/
|
|
export function getTempRoot(): string {
|
|
return os.tmpdir();
|
|
}
|
|
|
|
/**
|
|
* Create a temporary directory. If the prefix is an absolute path, use it directly;
|
|
* otherwise create the directory in the operating system's temporary directory.
|
|
* @param prefix a prefix for the directory name, or an absolute path prefix
|
|
*/
|
|
export async function mkdir(prefix: string) {
|
|
const baseDir = path.isAbsolute(prefix) ? prefix : path.join(getTempRoot(), prefix);
|
|
const result = await fs.promises.mkdtemp(baseDir);
|
|
++stats.numCreated;
|
|
pendingRemoval.push(result);
|
|
return result;
|
|
}
|
|
|
|
/**
|
|
* Synchronously create a temporary directory. If the prefix is an absolute path, use it directly;
|
|
* otherwise create the directory in the operating system's temporary directory.
|
|
* @param prefix a prefix for the directory name, or an absolute path prefix
|
|
*/
|
|
export function mkdirSync(prefix: string) {
|
|
const baseDir = path.isAbsolute(prefix) ? prefix : path.join(getTempRoot(), prefix);
|
|
const result = fs.mkdtempSync(baseDir);
|
|
++stats.numCreated;
|
|
pendingRemoval.push(result);
|
|
return result;
|
|
}
|
|
|
|
/**
|
|
* Remove all temporary directories created by this module.
|
|
*/
|
|
export async function cleanup() {
|
|
// "Atomically" take a copy of the things to remove and set it to an empty array.
|
|
const toRemove = pendingRemoval.splice(0, pendingRemoval.length);
|
|
let numRemoved = 0;
|
|
let numAlreadyGone = 0;
|
|
for (const dir of toRemove) {
|
|
if (!(await utils.dirExists(dir))) {
|
|
++stats.numAlreadyGone;
|
|
++numAlreadyGone;
|
|
continue;
|
|
}
|
|
try {
|
|
await fs.promises.rm(dir, {recursive: true, force: true});
|
|
++numRemoved;
|
|
++stats.numRemoved;
|
|
} catch (e) {
|
|
logger.error(`Failed to remove ${dir}: ${e}`);
|
|
}
|
|
}
|
|
logger.debug(`Removed ${numRemoved} (${numAlreadyGone} already gone) of ${toRemove.length} temporary directories`);
|
|
}
|
|
|
|
/**
|
|
* Synchronously remove all temporary directories created by this module; for use at process
|
|
* exit, where asynchronous work never runs.
|
|
*/
|
|
export function cleanupSync() {
|
|
const toRemove = pendingRemoval.splice(0, pendingRemoval.length);
|
|
for (const dir of toRemove) {
|
|
try {
|
|
if (!fs.existsSync(dir)) {
|
|
++stats.numAlreadyGone;
|
|
continue;
|
|
}
|
|
fs.rmSync(dir, {recursive: true, force: true});
|
|
++stats.numRemoved;
|
|
} catch {
|
|
// Best effort only: we may be partway through exiting.
|
|
}
|
|
}
|
|
}
|
|
|
|
process.on('exit', () => {
|
|
cleanupSync();
|
|
});
|