mirror of
https://github.com/beetbox/beets.git
synced 2026-05-17 06:00:56 -04:00
4ac0aa8a6a
- Prevents wrong last.fm genres based on a per artist (or global) list of regex
patterns that should be ignored.
- Genre _ignoring_ happens in two places but mainly:
- Right after fetching from last.fm
- and in _resolve_genres (via filter_valid or directly).
- As a fallback literal string matching can be used instead of
supplying a regex pattern
New methods:
- `artist_for_filter` to find out which (album)artist attribute is the
right one in a stage -> ignorelist is artist-based!
- `is_ignored` and `drop_ignored_genres`
- `load_ignorelist` uses confuse mechanisms to load patterns for each
artist and provide them to the plugin as self.ignore_patterns
60 lines
1.9 KiB
Python
60 lines
1.9 KiB
Python
# This file is part of beets.
|
|
# Copyright 2026, J0J0 Todos.
|
|
#
|
|
# Permission is hereby granted, free of charge, to any person obtaining
|
|
# a copy of this software and associated documentation files (the
|
|
# "Software"), to deal in the Software without restriction, including
|
|
# without limitation the rights to use, copy, modify, merge, publish,
|
|
# distribute, sublicense, and/or sell copies of the Software, and to
|
|
# permit persons to whom the Software is furnished to do so, subject to
|
|
# the following conditions:
|
|
#
|
|
# The above copyright notice and this permission notice shall be
|
|
# included in all copies or substantial portions of the Software.
|
|
|
|
|
|
"""Lastgenre plugin shared utilities and types."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
|
|
if TYPE_CHECKING:
|
|
import re
|
|
|
|
from beets.logging import BeetsLogger
|
|
|
|
GenreIgnorePatterns = dict[str, list[re.Pattern[str]]]
|
|
"""Mapping of artist name to list of compiled case-insensitive patterns."""
|
|
|
|
|
|
def drop_ignored_genres(
|
|
logger: BeetsLogger,
|
|
ignore_patterns: GenreIgnorePatterns,
|
|
genres: list[str],
|
|
artist: str | None = None,
|
|
) -> list[str]:
|
|
"""Drop genres that match the ignorelist."""
|
|
return [
|
|
g for g in genres if not is_ignored(logger, ignore_patterns, g, artist)
|
|
]
|
|
|
|
|
|
def is_ignored(
|
|
logger: BeetsLogger,
|
|
ignore_patterns: GenreIgnorePatterns,
|
|
genre: str,
|
|
artist: str | None = None,
|
|
) -> bool:
|
|
"""Check if genre tag should be ignored."""
|
|
genre_lower = genre.lower()
|
|
for pattern in ignore_patterns.get("*") or []:
|
|
if pattern.fullmatch(genre_lower):
|
|
logger.extra_debug("ignored (global): {}", genre)
|
|
return True
|
|
for pattern in ignore_patterns.get((artist or "").lower()) or []:
|
|
if pattern.fullmatch(genre_lower):
|
|
logger.extra_debug("ignored (artist: {}): {}", artist, genre)
|
|
return True
|
|
return False
|