mirror of
https://github.com/beetbox/beets.git
synced 2026-05-17 06:00:56 -04:00
142e946588
The fetchart plugin would silently drop unknown sources defined in config, leading to hard to debug problems. The plugin now errors when an unknown source is configured, or when no sources are configured. In addition, a single string is now a valid value for `sources` to either enable all sources with an `*` or a single source. Fixes: #6336
53 lines
1.3 KiB
Python
53 lines
1.3 KiB
Python
import pytest
|
|
|
|
from beets.util.config import UnknownPairError, sanitize_choices, sanitize_pairs
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"input_choices, valid_choices, expected",
|
|
[
|
|
(["A", "Z"], ("A", "B"), ["A"]),
|
|
(["A", "A"], ("A"), ["A"]),
|
|
(["D", "*", "A"], ("A", "B", "C", "D"), ["D", "B", "C", "A"]),
|
|
],
|
|
)
|
|
def test_sanitize_choices(input_choices, valid_choices, expected):
|
|
assert sanitize_choices(input_choices, valid_choices) == expected
|
|
|
|
|
|
def test_sanitize_pairs():
|
|
assert sanitize_pairs(
|
|
[
|
|
("foo", "baz bar"),
|
|
("foo", "baz bar"),
|
|
("key", "*"),
|
|
("*", "*"),
|
|
("discard", "bye"),
|
|
],
|
|
[
|
|
("foo", "bar"),
|
|
("foo", "baz"),
|
|
("foo", "foobar"),
|
|
("key", "value"),
|
|
],
|
|
) == [
|
|
("foo", "baz"),
|
|
("foo", "bar"),
|
|
("key", "value"),
|
|
("foo", "foobar"),
|
|
]
|
|
|
|
|
|
def test_sanitize_pairs_unknown_key():
|
|
with pytest.raises(UnknownPairError):
|
|
sanitize_pairs(
|
|
[("bar", "foo")], [("key", "value")], raise_on_unknown=True
|
|
)
|
|
|
|
|
|
def test_sanitize_pairs_unknown_key_wildcard_value():
|
|
with pytest.raises(UnknownPairError):
|
|
sanitize_pairs(
|
|
[("foo", "*")], [("key", "value")], raise_on_unknown=True
|
|
)
|