Commit Graph

707 Commits

Author SHA1 Message Date
Šarūnas Nejus
90099f128d Merge branch 'master' into fix-mpdstats-cli-host 2026-06-04 06:03:48 +01:00
Šarūnas Nejus
5804a21620 Fix autobpm tests 2026-06-03 18:00:46 +01:00
Šarūnas Nejus
ca8544d4bc Fix ftintitle tests 2026-06-03 18:00:46 +01:00
Šarūnas Nejus
544ea3af5d Fix mbcollection tests 2026-06-03 18:00:46 +01:00
Šarūnas Nejus
7bad226c33 Add setup fixture to TestHelper 2026-06-03 18:00:46 +01:00
Šarūnas Nejus
fb9de7a619 lyrics: fix musica parsing 2026-06-03 15:42:19 +01:00
Šarūnas Nejus
29580d2f00 Import everything from parent beets.autotag 2026-06-02 08:57:35 +01:00
Tsuizxgo
cf7c5e4eb2 Fix mpdstats CLI option overrides 2026-06-01 23:57:07 +08:00
Alok Saboo
672addeff4 remove capture_log 2026-06-01 10:46:57 +02:00
Alok Saboo
b7b2449371 simplify test 2026-06-01 10:46:57 +02:00
Alok Saboo
a333b307e3 remove optional test 2026-06-01 10:46:57 +02:00
Alok Saboo
4b554e9697 Batch SQLite commits and follow write-before-store pattern 2026-06-01 10:46:57 +02:00
Šarūnas Nejus
893df40534 Merge branch 'master' into fix/fetchart-permission-error-graceful 2026-05-29 17:33:13 +01:00
David Logie
621a401226 Simplify test. 2026-05-29 17:25:00 +01:00
David Logie
9c51b5c109 PR feedback. 2026-05-29 17:25:00 +01:00
David Logie
785f8b7a5c Make aliases-as-credits functionality opt-in.
This feature was introduced in 2.10 but results a lot of data being
overwritten with (potentially) incorrect data the next time a user runs
`mbsync` over their library.

To make this less of a "breaking" change, make this feature opt-in. The
users who want this large change can enable the functionality.
2026-05-29 17:25:00 +01:00
terminalchai
3aa44c5039 fetchart: add test and changelog for OSError handling in _set_art 2026-05-29 16:49:17 +01:00
Martin Caspersen
c2f8c65193 style: apply ruff formatting to test 2026-05-29 16:54:23 +02:00
Martin Caspersen
bbf786da92 Merge branch 'master' into fix/browse-recordings-missing-aliases 2026-05-29 16:52:41 +02:00
Martin Caspersen
31e18b2c4c refactor(musicbrainz): use direct aliases access and improve browse test
Replace defensive .get("aliases", []) with recording["aliases"] now that
"aliases" is in BROWSE_INCLUDES. Swap the graceful-fallback test for one
that asserts aliases from browse results take priority over the track title.
2026-05-29 16:50:23 +02:00
Sebastian Mohr
ed0c6fbbe6 I think it is a good time to move the PytestPluginTestHelper class. 2026-05-29 11:54:48 +02:00
benstev1
272d38ae0b Merge branch 'master' into feat/sylt-synchronized-lyrics 2026-05-27 14:33:45 -04:00
Martin Caspersen
ba798ae281 style: apply ruff formatting and address review comments
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-27 15:25:18 +02:00
Martin Caspersen
beb1610476 fix(musicbrainz): handle missing aliases in browse_recordings for large releases
When a release exceeds BROWSE_MAXTRACKS tracks, _ensure_complete_recordings
fetches recordings via browse_recordings. BROWSE_INCLUDES was missing "aliases",
so the API never returned alias data, causing a KeyError in get_tracks_from_medium.

Add "aliases" to BROWSE_INCLUDES and defensively use .get("aliases", []) at the
access site, consistent with all other alias lookups in the file.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-27 13:45:17 +02:00
Šarūnas Nejus
28321bd3e6 Remove default path_formats value only used in tests
Ensure that path_formats is set in relevant tests to avoid reliance on
defaults and to clarify test intent. Update Library constructor type hint for
path_formats to use Template type.

This default value was only relevant in tests.
2026-05-24 15:09:58 +01:00
Šarūnas Nejus
a0a88b5301 Handle BeetsHTTPError in mbcollection graciously 2026-05-24 15:00:25 +01:00
Maxr1998
1447282ad7 Pass tests 2026-05-24 01:33:00 +01:00
Maxr1998
acfeb0987f Fix formatting 2026-05-24 01:33:00 +01:00
Maxr1998
3eac908355 Add tests for file import 2026-05-24 01:33:00 +01:00
Maxr1998
b126598c2f Add tests for new behavior 2026-05-24 01:33:00 +01:00
Benjamin Stevenson
fc8217f576 merge: resolve changelog and poetry.lock conflicts with master 2026-05-21 19:50:06 -04:00
Benjamin Stevenson
85d5509baa fix: keep LRC in USLT, simplify synced_lyrics write path, fix poetry.lock 2026-05-21 19:48:37 -04:00
Sebastian Mohr
53060a4ba0 Reformatted 2026-05-21 16:55:05 +02:00
Sebastian Mohr
f7114266a4 Fold lines. 2026-05-21 16:54:50 +02:00
Sebastian Mohr
96a96bb4ec Removed typehints 2026-05-21 16:54:50 +02:00
Sebastian Mohr
39b1e21904 Removed unnecessary str typehint. 2026-05-21 16:54:50 +02:00
Sebastian Mohr
d90f22f8e5 Moved to requests_mock fixtures:
- Renamed image_response_mocker to image_request_mock
- Use requests_mock.mocker.Mocker instead of responses.RequestsMock
- Renamed function add to get
2026-05-21 16:54:50 +02:00
Sebastian Mohr
59ba8ad21b Moved PytestTestHelper into test/helper.py 2026-05-21 16:54:50 +02:00
Sebastian Mohr
2fea2efc4a Fixed logic inversion in cleanup fixture. 2026-05-21 16:54:50 +02:00
Sebastian Mohr
65bceb4f49 Fixed a number of typing issues. 2026-05-21 16:54:50 +02:00
Sebastian Mohr
a99c7caf37 EmbedartCliTest -> TestEmbedartCli
use the new image_response_mocker and pytest setup
2026-05-21 16:54:50 +02:00
Sebastian Mohr
f3c1663536 TestAAO use image_response_mocker 2026-05-21 16:54:50 +02:00
Sebastian Mohr
349fcce72a ArtImporterTest -> TestArtImporter 2026-05-21 16:54:50 +02:00
Sebastian Mohr
0172436592 CombinedTest -> TestCombined 2026-05-21 16:54:50 +02:00
Sebastian Mohr
30898f7dfd TestFetchImage use image_response_mocker 2026-05-21 16:54:50 +02:00
Sebastian Mohr
5d427aa159 GoogleImageTest -> TestGoogleImage 2026-05-21 16:54:50 +02:00
Sebastian Mohr
8e919fd4f8 ITunesStoreTest -> TestITunesStore 2026-05-21 16:54:50 +02:00
Sebastian Mohr
e59f2f9047 FanartTVTest -> TestFanartTV 2026-05-21 16:54:50 +02:00
Sebastian Mohr
45bb25741c CoverArtArchiveTest -> TestCoverArtArchive: Uses new
image_response_mocker instead of class inheritance. Aligns more
with pytest imo
2026-05-21 16:54:50 +02:00
Sebastian Mohr
91d5f5aef8 CAAHelper -> CAAData: The functions here are not needed anymore as they
are now provided by the imageResponseMocker. Also fixed indenting of
json blocks.
2026-05-21 16:54:39 +02:00