Trey Turner
5d2280013a
test(ftintitle): remove mostly redundant test_trackinfo_received_preserves_collaborative_artist_credit
2026-07-08 22:02:12 -05:00
Trey Turner
617bfd6a92
fix(ftintitle): remove singleton handling as out of scope
2026-07-08 21:53:00 -05:00
Trey Turner
6132297fa1
test(ftintitle): remove item_data["artist"] assertion from artist_credit test
2026-07-08 21:53:00 -05:00
Trey Turner
b88390fc32
refactor(ftintitle): abstract ft_in_info into ft_in_title
2026-07-08 21:52:52 -05:00
Trey Turner
5738a8a0f1
test(ftintitle): remove artist_credit tests
2026-07-08 21:10:48 -05:00
Trey Turner
9abe96355b
fix(ftintitle): defer inclusion of artist_credit, review cleanup
2026-07-08 21:10:48 -05:00
Trey Turner
61f8c94e7f
fix(hooks): remove cached property invalidation
2026-07-08 21:10:48 -05:00
Trey Turner
1160d31cfa
feat(ftintitle): hook metadata events, fixing mbsync
2026-07-08 21:10:47 -05:00
Šarūnas Nejus
230bf19c7f
Remove redundant test logic exposed by full coverage
...
- Removing the coverage omit configuration exposed unused branches, helpers, and
fixtures across the test suite.
- Delete that redundant logic and simplify affected tests while preserving their
behavior.
2026-07-07 15:57:35 +01:00
Sebastian Mohr
54a2bd20e1
Removed This file is part of beets... headers.
2026-06-29 11:20:15 +02:00
Trey Turner
c1de81d59c
fix(ftintitle): parenthetical features
2026-06-18 19:47:43 -05:00
Šarūnas Nejus
ca8544d4bc
Fix ftintitle tests
2026-06-03 18:00:46 +01:00
Sebastian Mohr
adfb73b66d
Run ruff format
2026-05-20 16:53:06 +02:00
Fredrik Möllerstrand
bfd95f47d0
fix: ftintitle can handle a list of ampersanded artists
...
This was inspired by real life events:
https://musicbrainz.org/release/7c4d7a15-6b30-4bef-8b20-af200186fbdb
by the artist Danny L Harle has a a track with a featuring list
that contains "Danny L Harle, Oklou & MNEK".
2026-03-02 14:53:23 +00:00
Šarūnas Nejus
1c87da2c05
Fix test failures
2026-02-10 00:53:20 +00:00
Šarūnas Nejus
b964d8b7eb
Configure future-annotations
2026-01-13 20:55:40 +00:00
Henry Oberholtzer
f7b05cb7db
ftintitle: fix changelog conflict
2026-01-08 12:20:25 -08:00
Trey Turner
b14755df88
fix(ftintitle): remaining opportunities for improvement
2026-01-01 15:39:17 -06:00
Trey Turner
87a61fa8fa
Merge branch 'master' into feat/ftintitle/insert_featured_artist_before_variant_clauses
2025-12-20 02:32:06 -06:00
Trey Turner
00792922b5
fix: address remaining review comments
2025-12-20 02:19:54 -06:00
Matthew Kay
9ba3e12e8f
Fix ftintitle plugin to prioritize explicit featuring tokens
...
- Prioritize explicit featuring tokens (feat, ft, featuring) over generic
separators (&, and) when splitting artist names
- Prevents incorrect splits like 'Alice & Bob feat Charlie' from splitting
on '&' instead of 'feat'
- Add test cases to verify the fix
2025-12-10 20:52:37 +00:00
asardaes
9c37f94171
Add album template value in ftintitle plugin
2025-11-21 18:31:59 +01:00
Trey Turner
3051af9eb6
fix: abstract insert_ft_into_title, move bracket_keywords and find_bracket_position inside plugin
2025-11-17 13:04:31 -06:00
Trey Turner
3dd3bf5640
fix: address sourcery comments
2025-11-17 13:04:31 -06:00
Trey Turner
15daebb55f
test(ftintitle): mock import task to exercise import hooks
2025-11-17 13:04:31 -06:00
Trey Turner
1d239d6e27
feat(ftintitle): Insert featured artist before track variant
2025-11-17 13:04:31 -06:00
Šarūnas Nejus
d486885af3
pyupgrade Python 3.10
2025-11-08 12:09:52 +00:00
Jacob Danell
027b775fcd
Change arg name
2025-10-20 15:22:27 +02:00
Ember Light
ca8df30ec3
Add missing test parameter
2025-10-16 19:06:56 +02:00
Ember Light
f275835cd3
Add test
2025-10-16 18:49:24 +02:00
Ember Light
b95a17d8d3
remove feat from custom_feat_words
2025-10-12 22:40:27 +02:00
Ember Light
37a5f9cb15
Add custom feat words
2025-10-12 20:47:51 +02:00
Trey Turner
042b5d64eb
test(ftintitle): fix flake, massage mypy
2025-09-21 22:27:11 +01:00
Trey Turner
6ad7c5489c
test(ftintitle): parameterize tests
2025-09-21 22:27:11 +01:00
Trey Turner
f0a6059685
feat(FtInTitle): support tracks by artists != album artist
2025-09-21 22:27:11 +01:00
Šarūnas Nejus
d93ddf8dd4
Do not use explicit indices for logging args when not needed
2025-08-30 23:10:21 +01:00
Karl Besser
37879d0b18
Remove redundant unit tests for ftintitle plugin
...
Remove redundant unit tests for the `ftintitle.cotains_feat` function
2024-10-01 15:55:38 -05:00
Karl Besser
669307c91c
Update ftintitle.contains_feat unit tests
...
Since the `for_artist` keyword has been removed from
`ftintitle.contains_feat`, the unit tests need to be updated.
This includes the deletion of the test cases that test the
`for_artist=True` delimiters.
2024-09-30 10:28:23 -05:00
Karl Besser
6cb2e5926b
Add unit tests for separate "feat. X" detection
...
The unit tests for the `ftintitle.contains_feat` function are now split
up for artist and title matching.
2024-09-26 17:22:25 -04:00
Karl Besser
6c8bd424e8
Add unit tests to test new feat. X detection regex
...
The previous version of the `plugins.feat_tokens` regular expression
only matched "feat. X" parts if preceded by a space. This caused missed
detections in the `ftintitle.contains_feat` function.
This commit adds unit tests for the updated regex that also matches
"feat. X" parts within parentheses and brackets
2024-09-22 18:30:28 -04:00
Šarūnas Nejus
f36bc497c8
Fix lint issues
...
- Fix imports
- Fix pytest issues
- Do not assign lambda as variable
- Use isinstance instead of type to check type
- Rename ambiguously named variables
- Name custom errors with Error suffix
2024-09-21 11:59:18 +01:00
Šarūnas Nejus
85a17ee503
Reformat the codebase
2024-09-21 11:57:48 +01:00
Karl-Ludwig Besser
39acba5200
Merge branch 'master' into ftintitle_keep_artist
2024-09-05 12:32:20 +02:00
Šarūnas Nejus
9a05d27acf
Replace assertEqual
2024-08-12 08:43:42 +01:00
Šarūnas Nejus
cb82917fe0
Replace assertFalse
2024-08-12 08:43:41 +01:00
Šarūnas Nejus
0ecc345143
Replace assertTrue
2024-08-05 17:11:16 +01:00
Šarūnas Nejus
fcff5d72af
Remove def suite TestLoader definitions
2024-07-28 18:58:51 +01:00
Šarūnas Nejus
432da560e4
Create PluginTestCase to dedupe plugin setup
2024-07-28 18:58:35 +01:00
Šarūnas Nejus
2d5fd907c3
Remove redundant setup_beets and teardown_beets instructions
2024-07-28 18:58:34 +01:00
Šarūnas Nejus
6c1e26acc9
Replace unittest.TestCase, TestHelper by BeetsTestCase
2024-07-28 18:58:34 +01:00
