mirror of
https://github.com/ankitects/anki.git
synced 2026-07-28 17:18:55 -04:00
100 lines
2.8 KiB
Python
100 lines
2.8 KiB
Python
# Copyright: Ankitects Pty Ltd and contributors
|
|
# License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
|
|
|
|
import os.path
|
|
from tempfile import TemporaryDirectory
|
|
from zipfile import ZipFile
|
|
|
|
import pytest
|
|
from mock import MagicMock
|
|
|
|
from aqt.addons import AddonManager, package_name_valid
|
|
|
|
|
|
def test_readMinimalManifest():
|
|
assertReadManifest(
|
|
'{"package": "yes", "name": "no"}', {"package": "yes", "name": "no"}
|
|
)
|
|
|
|
|
|
def test_readExtraKeys():
|
|
assertReadManifest(
|
|
'{"package": "a", "name": "b", "mod": 3, "conflicts": ["d", "e"]}',
|
|
{"package": "a", "name": "b", "mod": 3, "conflicts": ["d", "e"]},
|
|
)
|
|
|
|
|
|
def test_invalidManifest():
|
|
assertReadManifest('{"one": 1}', {})
|
|
|
|
|
|
def test_mustHaveName():
|
|
assertReadManifest('{"package": "something"}', {})
|
|
|
|
|
|
def test_mustHavePackage():
|
|
assertReadManifest('{"name": "something"}', {})
|
|
|
|
|
|
def test_invalidJson():
|
|
assertReadManifest("this is not a JSON dictionary", {})
|
|
|
|
|
|
def test_missingManifest():
|
|
assertReadManifest(
|
|
'{"package": "what", "name": "ever"}', {}, nameInZip="not-manifest.bin"
|
|
)
|
|
|
|
|
|
def test_ignoreExtraKeys():
|
|
assertReadManifest(
|
|
'{"package": "a", "name": "b", "game": "c"}', {"package": "a", "name": "b"}
|
|
)
|
|
|
|
|
|
def test_conflictsMustBeStrings():
|
|
assertReadManifest(
|
|
'{"package": "a", "name": "b", "conflicts": ["c", 4, {"d": "e"}]}', {}
|
|
)
|
|
|
|
|
|
def assertReadManifest(contents, expectedManifest, nameInZip="manifest.json"):
|
|
with TemporaryDirectory() as td:
|
|
zfn = os.path.join(td, "addon.zip")
|
|
with ZipFile(zfn, "w") as zfile:
|
|
zfile.writestr(nameInZip, contents)
|
|
|
|
adm = AddonManager(MagicMock())
|
|
|
|
with ZipFile(zfn, "r") as zfile:
|
|
assert adm.readManifestFile(zfile) == expectedManifest
|
|
|
|
|
|
def test_package_name_validation():
|
|
assert not package_name_valid("")
|
|
assert not package_name_valid("/")
|
|
assert not package_name_valid("a/b")
|
|
assert not package_name_valid("..")
|
|
assert package_name_valid("ab")
|
|
|
|
|
|
@pytest.fixture
|
|
def addon_manager(tmp_path) -> AddonManager:
|
|
adm = AddonManager(MagicMock())
|
|
adm.mw.pm.addonFolder.return_value = tmp_path
|
|
return adm
|
|
|
|
|
|
def test_install_extracts_safe_files(tmp_path, addon_manager):
|
|
zfn = os.path.join(tmp_path, "addon.zip")
|
|
with ZipFile(zfn, "w") as zfile:
|
|
zfile.writestr("main.py", "content")
|
|
zfile.writestr("../unsafe.txt", "content")
|
|
zfile.writestr("subdir/helper.py", "content")
|
|
with ZipFile(zfn) as zfile:
|
|
addon_manager._install("12345", zfile)
|
|
addon_dir = os.path.join(tmp_path, "12345")
|
|
assert os.path.exists(os.path.join(addon_dir, "main.py"))
|
|
assert os.path.exists(os.path.join(addon_dir, "subdir", "helper.py"))
|
|
assert not os.path.exists(os.path.join(tmp_path, "unsafe.txt"))
|